Implement User Memory Feature for Enhanced Conversational Context #1818

wenzhengjiang · 2025-09-13T00:43:28Z

This PR introduces a User Memory feature to enhance the AI's contextual awareness and personalization. It includes two components: "Recent Conversations" for automatic, short-term context from chat history, and "Saved Memories" for long-term, user-directed information storage.

Key changes include the UserMemoryManager to handle memory operations, new settings for configuration, and seamless integration of memory context into the LLM system prompt.

See https://github.com/logancyang/obsidian-copilot/blob/3da77b4ddf247c2f0b659e1e5f912ebf4dd36d9a/src/memory/memory-design.md for implementation design details.

- Removed user insights extraction and storage logic - Simplified UserMemoryManager to focus only on recent conversations - Updated memory design documentation to reflect current implementation - Maintains recent conversation tracking with 40-line rolling buffer - No breaking changes to public API

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Uncached system prompt with memory retrieval ▹ view
	Hardcoded memory configuration values ▹ view
	Repeated system prompt generation without caching ▹ view
	Prompt injection vulnerability in LLM calls ▹ view
	SRP violation in sendMessage method ▹ view	✅ Fix detected
	SRP violation: memory-analysis logic lives in UI tab ▹ view
	Hardcoded memory folder path may cause conflicts ▹ view
	Memory field not restricted to user messages ▹ view	✅ Fix detected

Files scanned

File Path	Reviewed
src/types/message.ts	✅
src/settings/SettingsPage.tsx	✅
src/settings/v2/components/CopilotPlusSettings.tsx	✅
src/core/MessageRepository.ts	✅
src/LLMProviders/chainManager.ts	✅
src/core/ChatManager.ts	✅
src/main.ts	✅
src/settings/model.ts	✅
src/components/Chat.tsx	✅
src/LLMProviders/chainRunner/AutonomousAgentChainRunner.ts	✅
src/constants.ts	✅
src/LLMProviders/chainRunner/CopilotPlusChainRunner.ts	✅
src/memory/UserMemoryManager.ts	✅
src/LLMProviders/projectManager.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

src/constants.ts

src/settings/SettingsPage.tsx

src/memory/UserMemoryManager.ts

src/LLMProviders/chainRunner/AutonomousAgentChainRunner.ts

src/core/ChatManager.ts

src/LLMProviders/chainRunner/CopilotPlusChainRunner.ts

src/types/message.ts

logancyang · 2025-09-13T01:22:16Z

bugbot run

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Missing validation criteria explanation ▹ view	✅ Fix detected
	Incorrect log level for error condition ▹ view	✅ Fix detected
	Incorrect log level for error condition ▹ view	✅ Fix detected
	Misleading async method naming ▹ view	✅ Fix detected
	Missing purpose explanation in condensed message documentation ▹ view	✅ Fix detected
	Unnecessary function binding in filter ▹ view	✅ Fix detected
	Inconsistent chain manager usage in memory operations ▹ view	✅ Fix detected

Files scanned

File Path	Reviewed
src/settings/model.ts	✅
src/memory/UserMemoryManager.ts	✅
src/core/ChatManager.ts	✅
src/LLMProviders/chainRunner/AutonomousAgentChainRunner.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

src/memory/UserMemoryManager.ts

+  /**
+   * Check if a message is a user message with valid condensed content
+   */
+  private hasValidCondensedUserMessage(message: ChatMessage): boolean {


src/memory/UserMemoryManager.ts

+    const conversationTitle = await this.extractConversationTitle(messages, chatModel);
+    const timestamp = new Date().toISOString().split(".")[0] + "Z"; // Remove milliseconds but keep Z for UTC
+    const userMessageTexts = messages
+      .filter(this.hasValidCondensedUserMessage.bind(this))


src/core/ChatManager.ts

+          const chainManager = this.plugin.projectManager.getCurrentChainManager();
+          const chatModel = chainManager.chatModelManager.getChatModel();


src/core/ChatManager.ts

+              }
+            })
+            .catch((error) => {
+              logInfo(`[ChatManager] Failed to create condensed message for ${messageId}:`, error);


src/core/ChatManager.ts

+            });
+        }
+      } catch (error) {
+        logInfo(`[ChatManager] Error setting up condensed message creation:`, error);


wenzhengjiang · 2025-09-13T08:12:48Z

bugbot run

…ation

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Tight coupling to utility function ▹ view	✅ Fix detected

Files scanned

File Path	Reviewed
src/memory/UserMemoryManager.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

src/memory/UserMemoryManager.ts

+    const settings = getSettings();
+    const memoryFolderPath = settings.memoryFolderName;
+
+    await ensureFolderExists(memoryFolderPath);


logancyang · 2025-09-13T16:30:14Z

bugbot run

logancyang · 2025-09-13T18:41:00Z

I ran codex on this diff, can you check if these are real issues @wenzhengjiang

Key Findings and Potential Issues

Memory referencing ignores the enable/disable toggle when building system prompt
- getSystemPromptWithMemory unconditionally reads memory content and adds <user_memory> if content exists, ignoring getSettings().enableMemory.
- Impact: Disabling "Reference Recent Conversation" does not prevent memory content from being included in the prompt if the memory file exists.
- Recommendation: Gate memory inclusion in getSystemPromptWithMemory by enableMemory.
Test mismatch with new folder creation utility
- UserMemoryManager.ensureMemoryFolderExists now calls ensureFolderExists, which uses global.app.vault.getAbstractFileByPath and app.vault.adapter.mkdir. UserMemoryManager.test.ts still expects vault.createFolder calls and injects a local mockApp.
- Impact: Tests may fail or not test intended paths due to mockApp.vault being stubbed while ensureFolderExists uses global.app, and __mocks__/obsidian.js lacks vault.adapter.mkdir.
- Recommendation: Update tests to mock global.app.vault.adapter.mkdir or refactor ensureFolderExists to take an App reference. Update __mocks__/obsidian.js to include vault.adapter = { mkdir: jest.fn() }.
Asynchronous race: condensedMessage may be missing during memory update
- Condensed message creation in ChatManager.createCondensedMessageAsync is asynchronous. Memory write via updateUserMemory(messages, chatModel) happens at "New Chat" time, with no guarantee all condensed messages are ready.
- Impact: Saved conversation messages may lack condensed bullets, reducing memory value.
- Recommendation: In UserMemoryManager.updateMemory, consider calling createCondensedMessage in-line for user messages lacking condensedMessage to backfill missing entries before finalizing the memory section.
Logger usage inconsistent in UI files
- Chat.tsx, SettingsPage.tsx, and settings components still use console.error.
- Guideline: "NEVER use console.log — use logging utilities."
- Impact: Inconsistent and unstructured logging.
- Recommendation: Replace remaining console.error instances with logError.
Global app usage vs. instance-based dependencies
- ensureFolderExists depends on global.app, while tests and managers inject their own app instances.
- Impact: Harder to test and reason about; potential breakage in non-Obsidian environments.
- Recommendation: Prefer dependency injection of app or ensure tests set global app consistently.
getSystemPrompt path inconsistency in deprecated chain paths
- chainManager.setChain still uses getSystemPrompt() (no memory) while chain runners call getSystemPromptWithMemory.
- Impact: If residual paths call chains directly, memory won't be included consistently.
- Recommendation: Remove deprecated chains if unused, or replace with getSystemPromptWithMemory(...).
Condensed message fallback may bloat memory
- When the LLM returns a condensed message that isn't shorter, the function returns the original full message.
- Impact: Potentially large bullets in memory, defeating the "condensed" intent.
- Recommendation: Clamp fallback to a maximum length (e.g., 160–200 chars) or retry with a more forceful prompt.
Minor UX/formatting review notes
- Conversation titles: "No summary" fallback might be better as "Untitled Conversation" or derived from the first user message.
- Key conclusions threshold: A hard threshold on conversationText length (300 chars) is simplistic; consider checking the number of exchanges or a token estimate.

Files/Areas Reviewed

src/memory/UserMemoryManager.ts (+ tests)
src/settings/model.ts (+ getSystemPromptWithMemory)
src/constants.ts (DEFAULT_SETTINGS + new fields)
src/LLMProviders/chainRunner/{CopilotPlusChainRunner, AutonomousAgentChainRunner}.ts (system prompt integration)
src/core/{ChatManager, MessageRepository}.ts
src/components/Chat.tsx, src/settings/SettingsPage.tsx, settings/v2/CopilotPlusSettings.tsx
src/utils.ts (ensureFolderExists)

Recommendations Summary

Gate memory inclusion in system prompt by enableMemory (bug).
Fix tests and/or mocks to work with ensureFolderExists and global.app.vault.adapter.mkdir, or refactor to inject app.
Replace remaining console.error with logError.
Backfill missing condensed messages during memory writes, or otherwise ensure condensation completes before writing.
Clamp condensed message fallback length.
Remove or harmonize deprecated chain usages of getSystemPrompt.

src/LLMProviders/chainManager.ts

src/types/message.ts

wenzhengjiang · 2025-09-15T08:40:51Z

I ran codex on this diff, can you check if these are real issues @wenzhengjiang

Key Findings and Potential Issues

Memory referencing ignores the enable/disable toggle when building system prompt

getSystemPromptWithMemory unconditionally reads memory content and adds <user_memory> if content exists, ignoring getSettings().enableMemory.

Impact: Disabling "Reference Recent Conversation" does not prevent memory content from being included in the prompt if the memory file exists.

Recommendation: Gate memory inclusion in getSystemPromptWithMemory by enableMemory.

Test mismatch with new folder creation utility

UserMemoryManager.ensureMemoryFolderExists now calls ensureFolderExists, which uses global.app.vault.getAbstractFileByPath and app.vault.adapter.mkdir. UserMemoryManager.test.ts still expects vault.createFolder calls and injects a local mockApp.

Impact: Tests may fail or not test intended paths due to mockApp.vault being stubbed while ensureFolderExists uses global.app, and __mocks__/obsidian.js lacks vault.adapter.mkdir.

Recommendation: Update tests to mock global.app.vault.adapter.mkdir or refactor ensureFolderExists to take an App reference. Update __mocks__/obsidian.js to include vault.adapter = { mkdir: jest.fn() }.

Asynchronous race: condensedMessage may be missing during memory update

Condensed message creation in ChatManager.createCondensedMessageAsync is asynchronous. Memory write via updateUserMemory(messages, chatModel) happens at "New Chat" time, with no guarantee all condensed messages are ready.

Impact: Saved conversation messages may lack condensed bullets, reducing memory value.

Recommendation: In UserMemoryManager.updateMemory, consider calling createCondensedMessage in-line for user messages lacking condensedMessage to backfill missing entries before finalizing the memory section.

Logger usage inconsistent in UI files

Chat.tsx, SettingsPage.tsx, and settings components still use console.error.

Guideline: "NEVER use console.log — use logging utilities."

Impact: Inconsistent and unstructured logging.

Recommendation: Replace remaining console.error instances with logError.

Global app usage vs. instance-based dependencies

ensureFolderExists depends on global.app, while tests and managers inject their own app instances.

Impact: Harder to test and reason about; potential breakage in non-Obsidian environments.

Recommendation: Prefer dependency injection of app or ensure tests set global app consistently.

getSystemPrompt path inconsistency in deprecated chain paths

chainManager.setChain still uses getSystemPrompt() (no memory) while chain runners call getSystemPromptWithMemory.

Impact: If residual paths call chains directly, memory won't be included consistently.

Recommendation: Remove deprecated chains if unused, or replace with getSystemPromptWithMemory(...).

Condensed message fallback may bloat memory

When the LLM returns a condensed message that isn't shorter, the function returns the original full message.

Impact: Potentially large bullets in memory, defeating the "condensed" intent.

Recommendation: Clamp fallback to a maximum length (e.g., 160–200 chars) or retry with a more forceful prompt.

Minor UX/formatting review notes

Conversation titles: "No summary" fallback might be better as "Untitled Conversation" or derived from the first user message.

Key conclusions threshold: A hard threshold on conversationText length (300 chars) is simplistic; consider checking the number of exchanges or a token estimate.

Files/Areas Reviewed

src/memory/UserMemoryManager.ts (+ tests)

src/settings/model.ts (+ getSystemPromptWithMemory)

src/constants.ts (DEFAULT_SETTINGS + new fields)

src/LLMProviders/chainRunner/{CopilotPlusChainRunner, AutonomousAgentChainRunner}.ts (system prompt integration)

src/core/{ChatManager, MessageRepository}.ts

src/components/Chat.tsx, src/settings/SettingsPage.tsx, settings/v2/CopilotPlusSettings.tsx

src/utils.ts (ensureFolderExists)

Recommendations Summary

Gate memory inclusion in system prompt by enableMemory (bug).

Fix tests and/or mocks to work with ensureFolderExists and global.app.vault.adapter.mkdir, or refactor to inject app.

Replace remaining console.error with logError.

Backfill missing condensed messages during memory writes, or otherwise ensure condensation completes before writing.

Clamp condensed message fallback length.

Remove or harmonize deprecated chain usages of getSystemPrompt.

Most issues discovered by codex are valid 👍

logancyang · 2025-09-16T00:29:37Z

bugbot run

src/settings/model.ts

wenzhengjiang added 14 commits August 29, 2025 16:31

Add memory setting

fb90c9e

Support recent conversation in memory

32e42c5

Add conversation summary to recent conversations

a51bbbe

Load recent conversation to prompt

1ee76ae

Implement user insights

6bb8528

Fix some bugs

0d86d43

Refactor

9e89ec9

Merge master into memory branch

16c6d98

Support returning multiple insights

52f7ad7

Use condensedMessage for recent conversation content

db08331

Add maxRecentConversations setting and update memory formatting

6dac374

Support multiple conclusions and add unit tests

e44c3d1

Merge master into memory branch

8841735

korbit-ai bot suggested changes Sep 13, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

wenzhengjiang added 2 commits September 13, 2025 10:27

Fix user message formatting

0a6b6fa

Fix PR issues

24bf217

korbit-ai bot suggested changes Sep 13, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

wenzhengjiang added 2 commits September 13, 2025 22:31

Refactor UserMemoryManager to utilize utility function for folder cre…

6c07880

…ation

Use logError for error logging

addbefd

korbit-ai bot suggested changes Sep 13, 2025

View reviewed changes

src/memory/UserMemoryManager.ts

const settings = getSettings();

const memoryFolderPath = settings.memoryFolderName;

await ensureFolderExists(memoryFolderPath);

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

logancyang reviewed Sep 13, 2025

View reviewed changes

src/LLMProviders/chainManager.ts Outdated Show resolved Hide resolved

logancyang reviewed Sep 13, 2025

View reviewed changes

src/types/message.ts Outdated Show resolved Hide resolved

Improve documentation and remove unused code

06b635c

wenzhengjiang added 9 commits September 15, 2025 17:52

Replace console.error with logError

3cd9eb5

Backfill condensedUserMessage

2ff8020

Fix build error

2a9ac44

Refactor for a simpiler implementation

c836de3

Better memory prompt and fix conversation parsing

cbe7b8c

Rename memory functions

502d57a

Implement memory tool.

1765366

Update design doc

3da77b4

Fix test

deac33b

cursor bot reviewed Sep 16, 2025

View reviewed changes

src/settings/model.ts Outdated Show resolved Hide resolved

wenzhengjiang added 2 commits September 16, 2025 09:53

Update savedMemory setting

9e3f501

Fix memory setting check

d867546

		const chainManager = this.plugin.projectManager.getCurrentChainManager();
		const chatModel = chainManager.chatModelManager.getChatModel();

Uh oh!

Implement User Memory Feature for Enhanced Conversational Context #1818

Are you sure you want to change the base?

Implement User Memory Feature for Enhanced Conversational Context #1818

Uh oh!

Conversation

wenzhengjiang commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

logancyang commented Sep 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

wenzhengjiang commented Sep 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

logancyang commented Sep 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

logancyang commented Sep 13, 2025

Key Findings and Potential Issues

Files/Areas Reviewed

Recommendations Summary

Uh oh!

Uh oh!

Uh oh!

wenzhengjiang commented Sep 15, 2025

Key Findings and Potential Issues

Files/Areas Reviewed

Recommendations Summary

Uh oh!

logancyang commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

wenzhengjiang commented Sep 13, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

korbit-ai bot left a comment •

edited

Loading