Skip to content

object_changed(): fix list comparison #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

object_changed(): fix list comparison #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions plugins/module_utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,21 @@


def object_changed(superset, subset, ignore=None):
def list_changed(lst2, lst):
if len(lst2) != len(lst):
return True
for i in range(len(lst)):
if type(lst[i]) == list:
if list_changed(lst2[i], lst[i]):
return True
elif type(lst[i]) == dict:
if len(lst2[i]) != len(lst[i]) or object_changed(lst2[i], lst[i]):
return True
else:
if lst[i] != lst2[i]:
return True
return False

changed_keys = []
for key, value in subset.items():
value2 = superset.get(key)
Expand All @@ -18,17 +33,10 @@ def object_changed(superset, subset, ignore=None):
elif ignore_value is None:
continue
if type(value) == list:
for i in range(len(value)):
if not value2:
changed_keys.append((key, superset.get(key), subset[key]))
elif type(value[i]) == list or type(value[i]) == dict:
if i >= len(value2) or object_changed(value2[i], value[i]):
changed_keys.append((key, superset.get(key), subset[key]))
else:
if value[i] != value2[i]:
changed_keys.append((key, superset.get(key), subset[key]))
if list_changed(value2, value):
changed_keys.append((key, superset.get(key), subset[key]))
elif type(value) == dict:
if object_changed(value2, value):
if len(value2) != len(value) or object_changed(value2, value):
changed_keys.append((key, superset.get(key), subset[key]))
else:
if value != value2:
Expand Down