Skip to content

Add an icon to 'Open theme folder' #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add an icon to 'Open theme folder' #1125

wants to merge 1 commit into from

Conversation

isf63
Copy link
Contributor

@isf63 isf63 commented May 17, 2025

This was part of a bigger experiment to add "Open icons folder" and "Open cursors folder" context menu and double click, as #854 does for LXQt themes. The complexity seemed too much, but may be do-able in the future.

This PR trivially adds an icon.

@tsujan
Copy link
Member

tsujan commented May 21, 2025

For reasons beyond this comment, the dialog of LXQt Appearances Configuration doesn't and can't follow symbolic icon colorization (although it enables/disables it correctly). So, it's preferable to avoid icons in it as far as possible.

In short, the reason is that it has to load all icon themes in its second page, and that ruins colorization inside the whole dialog.

@tsujan
Copy link
Member

tsujan commented May 21, 2025

To make it clearer it with an image:

color

@isf63
Copy link
Contributor Author

isf63 commented May 21, 2025

I guess I'm striking out with my recent PRs :-]

If you find time, please review the remaining lxqt/lxqt-themes#141. I will close the others fairly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants