Skip to content

panel: Use the wlroots backend with unknown Wayland compositors #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

panel: Use the wlroots backend with unknown Wayland compositors #2161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panel/lxqtpanelapplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ void LXQtPanelApplicationPrivate::loadBackend()
}
}

if ( preferredBackend.isEmpty() && xdgCurrentDesktops.contains( QStringLiteral("wlroots") ) )
if ( preferredBackend.isEmpty() && xdgSessionType == QStringLiteral("wayland") ) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wlroots backend should be used only if wlroots is included. That inclusion means, "we know that it works with this Wayland compositor." The dummy backed should be used with unsupported compositors.

Copy link
Member

@stefonarch stefonarch Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wlroots backend should be used only if wlroots is included. That inclusion means, "we know that it works with this Wayland compositor." The dummy backed should be used with unsupported compositors.

Well, "unsupported" here means we ship no configuration for it and session exit etc may not work, but I think we can still load the wlroots backend for them. If an user starts an unsupported compositor by its own it's up to him.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wlroots backend is what its name says; it's not the fallback. If we know that a compositor works with it — even when it isn't based on wlroots — we should include it in this category explicitly.

This PR is wrong and can create a mess.

{
qDebug() << "Specialized backend unavailable. Falling back to generic wlroots";
preferredBackend = QStringLiteral("wlroots");
Expand Down