add macports libcxx dependency on older macs for gdb #27203

i3roly · 2024-12-25T17:56:45Z

this will ensure older systems are able to build and use the latest gdb with minimal effort

hopefully other members on the macports squad will look into the macro nusiance that otherwise impedes a clean compilation

Description

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.7.5 11G63 x86_64
Xcode 4.2.1 4D502

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL in commit message?
checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?
checked that the Portfile's most important variants haven't been broken?

this will ensure older systems are able to build and use the latest gdb with minimal effort hopefully other members on the macports squad will look into the macro nusiance that otherwise impedes a clean compilation

barracuda156

This should be fixed.

barracuda156 · 2024-12-26T08:02:39Z

devel/gdb/Portfile

@@ -86,6 +86,13 @@ pre-configure {

 build.dir ${configure.dir}

+#older macs require a new libcxx
+if {${os.platform} eq "darwin" && ${os.major} < 15} {
+    configure.depends_lib-append port:macports-libcxx


This is wrong and gonna break builds on older OS. If you need this for libc++-consuming versions, please make it conditional accordingly.

i3roly · 2024-12-26T14:13:10Z

Can you please make the recommended changes?As far as I can tell, gdb requires a libc++ newer than the ones in lion and mountain lion. All that we need to do is ensure that older macs use macports-libcxx so gdb is happy Sent from my BlackBerry 10 smartphone on the Rogers network. From: Sergey FedorovSent: Thursday, 26 December 2024 1:03 AMTo: macports/macports-portsReply To: macports/macports-portsCc: gagan sidhu; AuthorSubject: Re: [macports/macports-ports] add macports libcxx dependency on older macs for gdb (PR #27203) @barracuda156 requested changes on this pull request. This should be fixed. In devel/gdb/Portfile:

@@ -86,6 +86,13 @@ pre-configure {

build.dir ${configure.dir} +#older macs require a new libcxx +if {${os.platform} eq "darwin" && ${os.major} < 15} { + configure.depends_lib-append port:macports-libcxx This is wrong and gonna break builds on older OS. If you need this for libc++-consuming versions, please make it conditional accordingly. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***> [ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#27203 (review)", "url": "#27203 (review)", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

barracuda156 · 2024-12-26T14:46:02Z

@i3roly What you seem to want is to switch libc++-using systems to legacy-support-supplied libc++ (which is somewhat newer than archaic system one). However, this is not just unneeded but also breaking for systems which do not use libc++ to begin with. So the correct condition must include not only macOS version (whichever appropriate), but also C++ runtime, so that macports-libcxx is used only when C++ runtime is libc++.

i3roly · 2024-12-26T15:14:47Z

i see what you’re saying. could you please provide the runtime check? lol Thanks, Gagan

…

On Dec 26, 2024, at 7:46 AM, Sergey Fedorov ***@***.***> wrote: @i3roly What you seem to want is to switch libc++-using systems to legacy-support-supplied libc++ (which is somewhat newer than archaic system one). However, this is not just unneeded but also breaking for systems which do not use libc++ to begin with. So the correct condition must include not only macOS version (whichever appropriate), but also C++ runtime, so that macports-libcxx is used only when C++ runtime is libc++. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

barracuda156 · 2024-12-26T17:09:32Z

i see what you’re saying. could you please provide the runtime check?

if {${os.platform} eq "darwin" && ${configure.cxx_stdlib} eq "libc++"} {

}

@barracuda156

per what @barracuda156 stated, it's better to have a check for the runtime since <=10.7 use libstdc++ as the default, where 10.7 was the first move to using/including libc++. this check will ensure older macs don't get rekt

aeiouaeiouaeiouaeiouaeiouaeiou · 2024-12-27T04:43:02Z

devel/gdb/Portfile

+#older macs require a new libcxx
+if {${os.platform} eq "darwin" && ${os.major} < 15 && ${configure.cxx_stdlib} eq "libc++"} {
+    configure.depends_lib-append port:macports-libcxx
+    configure.cxxflags-append    -L/opt/local/lib/libcxx


I don't get it why is hardcoded to /opt/local instead of ${prefix}.

i3roly · 2024-12-27T04:44:19Z

it shouldn’t be. i’ll fix that. thanks Thanks, Gagan

…

On Dec 26, 2024, at 9:43 PM, aeiouaeiouaeiouaeiouaeiouaeiou ***@***.***> wrote: @aeiouaeiouaeiouaeiouaeiouaeiou requested changes on this pull request. In devel/gdb/Portfile: > @@ -86,6 +86,13 @@ pre-configure { build.dir ${configure.dir} +#older macs require a new libcxx +if {${os.platform} eq "darwin" && ${os.major} < 15 && ${configure.cxx_stdlib} eq "libc++"} { + configure.depends_lib-append port:macports-libcxx + configure.cxxflags-append -L/opt/local/lib/libcxx I don't get it why is hardcoded to /opt/local instead of ${prefix}. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

i3roly · 2024-12-28T15:22:23Z

I have never seen this construct used:

configure.depends_lib-append

does it do anything?

i didn't either, but apparently it's used a lot. it's supposed to ensure that macports-libcxx is installed prior to gdb for older macs. look here for more examples of depends_lib-append: https://github.com/search?q=repo%3Amacports%2Fmacports-ports+depends_lib-append&type=code

2. you are using:
configure.cxxflags-append -L${prefix}/lib/libcxx

appending linker flags to the cxxflags. They should be appended to the ldflags.

okay i can do that.

3. you are not setting any cxx include flags so the headers from the new libcxx are not being used.

gdb isn't complaining about the lack of headers. i think the newer clang headers are being used, it's just not able to find the appropriate (newer) libcxx associated with these headers, as i've pasted below.

4. the legacysupport PG has a mechanism to do all this correctly.  Although the code in the PG does have an error in it nobody has fixed yet, it works anyway in almost all cases and does all this correctly. Have you tried that?
macports-ports/_resources/port1.0/group/legacysupport-1.1.tcl

Line 18 in d94ce21

# legacysupport.use_mp_libcxx: Use an update libcxx runtime from a recent macports clang build

yes, i have, but the problem is the libcxx isn't propagating towards the end of the build:

checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features by default... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std=gnu++17... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std=gnu++1z... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std=c++17... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with +std=c++17... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -h std=c++17... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std:c++17... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std=c++1z... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with +std=c++1z... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -h std=c++1z... no
checking whether /opt/local/bin/clang++-mp-17 supports C++17 features with -std:c++1z... no
configure: error: *** A compiler with support for C++17 language features is required.

so the root of the issue is that the macports-libcxx legacy portgroup macro isn't passing the library path so GDB's configure can detect it.

the purpose of depends_lib is to ensure that macports-libcxx is installed beforehand.

i don't think the legacy portgroup macro can enforce this? correct me if i'm wrong on that?

the headers are taken care of by the newer clang that has to be used.

i haven't tried with ldflags but i used your cxx-append as the catch-all since you have shown that it plumbs better, and i figured that it was the safest and best way. but i can try with ldflags too.

i3roly · 2024-12-28T16:20:36Z

oh i see what you’re saying. yes my apologies that prefix should be removed Thanks, Gagan

…

On Dec 28, 2024, at 9:19 AM, Ken ***@***.***> wrote: This is used a lot: depends_lib-append This has zero hits in searching the macports repo, other than in this PR: configure.depends_lib-append — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

remove configure. from depends_lib-append change cxxflags to ldflags

i3roly · 2024-12-28T16:49:43Z

so what would you recommend in this particular instance?

adding a line like the following?

configure.cppflags-append -I${prefix}/libcxx

i3roly · 2024-12-28T17:23:13Z

fwiw i noticed that even on sierra (10.12) with the bundled clang 9/xcode, that gdb also fails to build due to the c++17 stuff.

very surprised by this, but seems like the version check needs to be < 17 !

pretty interesting that no one has picked this up? hope i'm wrong, but default clt failed to install gdb.

i3roly · 2025-01-03T04:49:34Z

anybody? it's getting tiresome having to edit portfiles on vms.

add macports libcxx dependency on older macs for gdb

4cf154f

this will ensure older systems are able to build and use the latest gdb with minimal effort hopefully other members on the macports squad will look into the macro nusiance that otherwise impedes a clean compilation

macportsbot added type: bugfix type: enhancement maintainer: none labels Dec 25, 2024

barracuda156 suggested changes Dec 26, 2024

View reviewed changes

aeiouaeiouaeiouaeiouaeiouaeiou suggested changes Dec 27, 2024

View reviewed changes

use proper prefix. thanks @aeiouaeiouaeiouaeiouaeiouaeiou

c54aff5

incorporate suggestions by @kencu

cb09709

remove configure. from depends_lib-append change cxxflags to ldflags

increase compiler blacklist for gdb, since clang9 (sierra) also fails.

6746c4e

pretty interesting that no one has picked this up? hope i'm wrong, but default clt failed to install gdb.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

add macports libcxx dependency on older macs for gdb #27203

add macports libcxx dependency on older macs for gdb #27203

Uh oh!

i3roly commented Dec 25, 2024

Uh oh!

barracuda156 left a comment

Uh oh!

barracuda156 Dec 26, 2024

Uh oh!

i3roly commented Dec 26, 2024 via email

Uh oh!

barracuda156 commented Dec 26, 2024

Uh oh!

i3roly commented Dec 26, 2024 via email

Uh oh!

barracuda156 commented Dec 26, 2024

Uh oh!

aeiouaeiouaeiouaeiouaeiouaeiou Dec 27, 2024

Uh oh!

i3roly commented Dec 27, 2024 via email

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Dec 28, 2024 via email

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Jan 3, 2025

Uh oh!

Uh oh!

Uh oh!

add macports libcxx dependency on older macs for gdb #27203

Are you sure you want to change the base?

add macports libcxx dependency on older macs for gdb #27203

Uh oh!

Conversation

i3roly commented Dec 25, 2024

Description

Type(s)

Tested on

Verification

Uh oh!

barracuda156 left a comment

Choose a reason for hiding this comment

Uh oh!

barracuda156 Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

i3roly commented Dec 26, 2024 via email

Uh oh!

barracuda156 commented Dec 26, 2024

Uh oh!

i3roly commented Dec 26, 2024 via email

Uh oh!

barracuda156 commented Dec 26, 2024

Uh oh!

aeiouaeiouaeiouaeiouaeiouaeiou Dec 27, 2024

Choose a reason for hiding this comment

Uh oh!

i3roly commented Dec 27, 2024 via email

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Dec 28, 2024 via email

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Dec 28, 2024

Uh oh!

i3roly commented Jan 3, 2025

Uh oh!

Uh oh!