Skip to content

proftpd : update to 1.3.9 ; more databases ; config changes #27811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

proftpd : update to 1.3.9 ; more databases ; config changes #27811

wants to merge 1 commit into from

Conversation

BjarneDMat
Copy link
Contributor

@BjarneDMat BjarneDMat commented Mar 3, 2025 •
edited
Loading 

* update to version 1.3.9
* sysconfir & localstatedir into own subdirs
* mysql8 & postgresql* variants added
  addresses : https://trac.macports.org/ticket/43431
* modified patch to fix original m4 file
  reported : https://github.com/proftpd/proftpd/issues/1878
* autoconf : yes ; to re-create configure files due to patch
* DRY changes

Changes to be committed:
        modified:   net/proftpd/Portfile
        deleted:    net/proftpd/files/dynamic_lookup-11.patch
        new file:   net/proftpd/files/-Wimplicit-function-declaration
                to-do file
                https://github.com/proftpd/proftpd/issues/1879
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
Model Identifier: MacPro5,1                 Model Identifier: Macmini6,1
macOS 14.7.5 23H527 x86_64                  macOS 10.15.7 19H2026 x86_64
Xcode 16.2 16C5032a                         Xcode 12.4 12D4e
Command Line Tools 16.2.0.0.1.1733547573    Command Line Tools 12.4.0.0.1.1610135815
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@BjarneDMat BjarneDMat force-pushed the proftpd branch 2 times, most recently from 75e0c6e to e4a1f7d Compare March 4, 2025 21:33
@BjarneDMat BjarneDMat force-pushed the proftpd branch 2 times, most recently from cc365b6 to d6f6549 Compare March 14, 2025 20:59
@BjarneDMat BjarneDMat changed the title proftpd : updated to v 1.3.8c ; more databases ; config changes proftpd : updated to v 1.3.9 ; more databases ; config changes Apr 10, 2025
@BjarneDMat BjarneDMat mentioned this pull request May 13, 2025
Merged
dgilman
dgilman reviewed May 14, 2025
View reviewed changes
net/proftpd/Portfile
# remove the following two lines when updating to 1.3.10
use_autoconf yes
use_configure yes
configure.args --sysconfdir=${prefix}/etc/${name} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this imply users upgrading need to move config files from /etc/ to the /etc/proftpd directory? if so, should probably be noted with a port note.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm i see the post-activate that takes care of this, maybe it does not need the note

barracuda156
barracuda156 reviewed May 14, 2025
View reviewed changes
net/proftpd/Portfile Outdated
--localstatedir=${prefix}/var/run \
# remove the following two lines when updating to 1.3.10
use_autoconf yes
use_configure yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen these two used at he same time. Also use_configure is the default anyway. It probably should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested without use_configure yes - removing it
🤔 in my defense, I was "using both suspenders and belt"

net/proftpd/Portfile Outdated
depends_build port:libtool
# remove autoconf when updating to 1.3.10
depends_build port:libtool \
port:autoconf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least autoconf dependency should be already added by use_autoconf. What does port lint say?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

#=> port lint proftpd
--->  Verifying Portfile for proftpd
--->  0 errors and 0 warnings found.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reneeotten Doesn’t use_autoconf imply a dependency automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does imply the dependency on port:autoconf - removing it

#=> port -cuN uninstall proftpd
#=> port -cuN uninstall autoconf
#=> port install proftpd
--->  Computing dependencies for proftpd
The following dependencies will be installed:  autoconf
Continue? [Y/n]: 
--->  Fetching archive for autoconf

@BjarneDMat BjarneDMat requested a review from barracuda156 May 20, 2025 14:15
@BjarneDM
proftpd : updated to v/ 1.3.9 ; more databases ; config changes
8196c37 
* update to version 1.3.9
* sysconfir & localstatedir into own subdirs
* mysql8 & postgresql* variants added
  addresses : https://trac.macports.org/ticket/43431
* modified patch to fix original m4 file
  reported : proftpd/proftpd#1878
* autoconf : yes ; to re-create configure files due to patch
* DRY changes

Changes to be committed:
	modified:   net/proftpd/Portfile
	deleted:    net/proftpd/files/dynamic_lookup-11.patch
	new file:   net/proftpd/files/-Wimplicit-function-declaration
		to-do file
		proftpd/proftpd#1879
@BjarneDMat BjarneDMat changed the title proftpd : updated to v 1.3.9 ; more databases ; config changes proftpd : update to 1.3.9 ; more databases ; config changes Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgilman dgilman dgilman approved these changes

@barracuda156 barracuda156 Awaiting requested review from barracuda156

Assignees
No one assigned
Labels
maintainer: none type: enhancement type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BjarneDMat @dgilman @barracuda156 @macportsbot @BjarneDM