xschem: new port of xschem schematic editor for EDA #28171
Conversation
There was a problem hiding this comment.
thanks for the submission @bpdegnan and apologies for the delay. Please find above/below some question/suggestions/requests.
| PortSystem 1.0 | ||
|
|
||
| name xschem | ||
| version 3.4.6 |
There was a problem hiding this comment.
latest upstream version is 3.4.7 by now
There was a problem hiding this comment.
I tried to get 3.4.7 to download through the existing framework on sourceforge, but I was unable to do so. I also have not extensively tested 3.4.7, and for that reason we are using 3.4.6 until I can get a chance to give it some testing.
science/xschem/Portfile
Outdated
| homepage https://xschem.sourceforge.io/stefan/index.html | ||
|
|
||
| distname ${name}-${version} | ||
| master_sites master_sites sourceforge:xschem |
There was a problem hiding this comment.
duplication of master_sites
science/xschem/Portfile
Outdated
| port:tk \ | ||
| port:xorg-libX11 | ||
|
|
||
| use_configure yes |
There was a problem hiding this comment.
this is the default, please remove
science/xschem/Portfile
Outdated
| port:xorg-libX11 | ||
|
|
||
| use_configure yes | ||
| configure.args --prefix=${prefix} |
There was a problem hiding this comment.
this is the default, please remove
science/xschem/Portfile
Outdated
|
|
||
| set docdir ${prefix}/share/doc/${name} | ||
|
|
||
| depends_build port:pkgconfig |
There was a problem hiding this comment.
this should become path:bin/pkg-config:pkgconfig so that the pkgconf port can also satisfy the dependence
| set docdir ${prefix}/share/doc/${name} | ||
|
|
||
| depends_build port:pkgconfig | ||
| depends_lib port:cairo \ |
There was a problem hiding this comment.
you. might want to include path:include/turbojpeg.h:libjpeg-turbo \ here as well since the configure script looks for it.
There appear to be more dependencies listed than upstream gives as required/optional.... For example, where does freetype, Xft2, readline come from? I suggest to take another close look at the requirements here.
There was a problem hiding this comment.
I removed a bunch of stuff here, and honestly, I don't recall why I needed it. I have been using macports to support my local software for awhile, and I think a lot of this was legacy. I was able to strip out all of those except xpm.
| port:readline \ | ||
| port:tcl \ | ||
| port:tk \ | ||
| port:xorg-libX11 |
There was a problem hiding this comment.
also please align the dependencies in the same was as the rest of the Portfile - why four additional spaces here?
There was a problem hiding this comment.
I think I got this.
| set sharedir ${destroot}${prefix}/share/xschem | ||
| set docdir ${destroot}${prefix}/share/doc/${name} | ||
|
|
||
| xinstall -d ${bindir} ${sharedir} ${docdir} |
There was a problem hiding this comment.
I am pretty sure that MacPorts creates the bin and share directory already so that seems redundant, please double check
| use_configure yes | ||
| configure.args --prefix=${prefix} | ||
|
|
||
| destroot { |
There was a problem hiding this comment.
overriding the complete destroot phase is a bit unconventional; is there no install target that will take care of some of these things already? If you need to copy extra stuff, you would typically do that in a post-destroot phase.
There was a problem hiding this comment.
I hope that I got this updated correctly. I, honestly, don't know what I was thinking.
|
ping @bpdegnan |
|
Please excuse the slow responses. I'm neck deep in a semiconductor tapeout and haven't looked at much else but pushing rectangles. |
Description
xschem: new port for Xschem schematic editor
Type(s)
new Portfile
Tested on
macOS 13.7.5 22H527 x86_64
Xcode 14.3.1 14E300c
Verification
Have you
port lint?sudo port test?sudo port -vst install?