-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update uhd to 4.8.0.0 #28475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update uhd to 4.8.0.0 #28475
Conversation
Notifying maintainers: |
This is the same as #27426 except against the latest macports and updated to 4.8.0.0 as the logs had expired on the old one. However... I downloaded the logs and I can't see what the actual error is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- followed our Commit Message Guidelines?
You didn't follow the commit message guidelines.
science/uhd/Portfile
Outdated
github.setup EttusResearch uhd 4.8.0.0 v | ||
checksums rmd160 8efc172de52be82dcfeb64a306fad14be93cb361 \ | ||
sha256 a2159491949477dca67f5a9b05f5a80d8c2b32e91b95dd7fac8ddd3893e36d09 \ | ||
size 41358938 | ||
revision 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating the version
, the revision
should drop to 0
.
revision 7 | |
revision 0 |
science/uhd/Portfile
Outdated
# Change github.tarball_from to 'releases' or 'archive' next update | ||
github.tarball_from tarball |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the github.tarball_from
line and the comment about how that line should be changed with the next update without following its instructions. Please add the line github.tarball_from releases
or github.tarball_from archive
, whichever is appropriate for this software, and update the checksums accordingly.
CI failed because it could not download uhd-4.8.0.0.tar.gz from https://github.com/EttusResearch/uhd/releases/download/v4.8.0.0. Looking at https://github.com/EttusResearch/uhd/releases/tag/v4.8.0.0, I see that it offers a file uhd-images_4.8.0.0.tar.xz. If that is the right file, then set github.tarball_from releases
and distname uhd-images_${version}
and use_xz yes
.
If this did not fail to build for you, that suggests your local ports tree is fairly out of date, because the default value of github.tarball_from
in the github portgroup was changed four months ago in b0f3e97. Please make sure your ports tree is up to date before you make and submit updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, fixed now.
The images are a separate thing (precompiled FPGA bit streams) - it seems the source is only available as tgz.
It didn't fail for me because I manually download the tarball then forgot to check the fetch worked later..
* Update uhd to 4.8.0.0 * Use boost 1.76 * Remove now unnecessary patch (was a backport) * Fix lint warning
@DanielO Thanks for working on the UHD update! My strong preference is to make a 3.15lts subport from the current "uhd" port so that it's still available for people who use it. Use (I think) "replaced_ by" from "uhd" to "uhd-3.15lts" so that people using this current "uhd" version are not forced to move to version 4.8.0.0 (same project name, very different API & how things work under the hood). Then create a new subport for UHD 4.8 ("uhd-4.8") as well as update uhd-devel to the latest commit from public uhd repo. Add a note that on the next UHD update we change the current "replaced_by" from "uhd-4.8" to "uhd" to transition people who have installed "uhd-4.8" from that to the general "uhd" port. By then, anyone using UHD 3.15 and keeping MP up to date will have transitioned to the new subport for that version, and it makes sense to move the general uhd port to the latest version. These changes will take a bit of work, but they provide the most robust path for current UHD MP users. If you don't want to go through this process, then just change the "uhd-devel" port to point to the 4.8.0.0 release |
Hmm well the only reason I updated it in the first place is that it does not build on the latest macOS, so I would prefer the main port actually work otherwise things like gnuradio are unbuildable.. Edit: went off on a tangent. I think it should build on the current version of macOS - I think that is less painful for more people than some hypothetical users which can't switch over to 3.15lts when they upgrade.. |
Also fix lint warning.
Description
Update uhd.
Tested by building and running gnuradio companion.
Type(s)
Tested on
macOS 15.4.1 24E263 x86_64
Xcode 16.3 16E140
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?