-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix all postgresql server commands in launchctl wrappers and installation notes #28575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Notifying maintainers: |
dd5334f
to
7e137d7
Compare
Failures are due to failing to install dependencies for older versions, most if not all are already marked as known to be failing |
Just nobody bothered to fix them after breaking by openssl default version change. They should use openssl PG with 1.0 branch, as I recall. Not a path to openssl.dylib, which pick an incompatible 3.0. Maybe a few minor tweaks to the portfile. Last time when I needed some old postgresql9x, it did not take much to fix the build. |
su command fails, as postgres shell is set to /usr/bin/false
su command fails, as postgres shell is set to /usr/bin/false
8dda919
to
997334d
Compare
Thank you for the build fixes |
Description
Wrappers created for postgresqlNN-server before 16 use
su
instead ofsudo
to execute as postgres, but postgres has shell set to/usr/bin/false
, sosu
commands fail. See https://trac.macports.org/ticket/68412 which fixed it for postgresql16-server and #14331 which fixed it for postgresql96-server.While resolving build errors (following a nudge from @barracuda156):
PortGroup openssl
with branch 1, 1.1 or 3exit
function without header) and usage of incompatible function in xml.c (without const qualifier where one is expected, it apparently switched by default from a warning to an error in osx 14)clang: error: unsupported option '-mthreads' for target 'arm64-apple-darwin23.6.0'
for <= 9.0../../../../src/include/storage/s_lock.h:937:2: error: PostgreSQL does not have native spinlock support on this platform. To continue the compilation, rerun configure using --disable-spinlocks. However, performance will be poor. Please report this to pgsql-bugs@postgresql.org.
for 9.1spinlock
problem can probably be fixed by adding handling for arm64 as in 9.2 and problems with threads I didn't look into, but I would prefer to leave it for nowType(s)
Tested on
macOS 14.7.5 23H527 arm64
Xcode 16.2 16C5032a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?