Skip to content

add port files for cdk and cdk-perl #28577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ThomasDickey
Copy link
Contributor

@ThomasDickey ThomasDickey commented May 30, 2025

Description

Add port files for cdk and cdk-perl

Type(s)

submission (new Portfile)

  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.5 24F74 x86_64
Xcode 16.3 16E140

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ThomasDickey - a few comments

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
@ryandesign
Copy link
Contributor

Commit message guidelines were not followed.

There are now two commits in this PR so it is not squashed and minimized.

We can correct both problems with the "Squash and merge" button later.

There is a lint warning:

Warning: cdk is configured to build for the architecture(s) 'arm64', but did not install any Mach-O files.

If cdk doesn't install anything architecture-specific, add supported_archs noarch. If it doesn't install anything that varies by OS type or version, add platforms any.

Signed-off-by: Thomas E. Dickey <dickey@invisible-island.net>
@ThomasDickey
Copy link
Contributor Author

ThomasDickey commented Jun 16, 2025

cdk installs an architecture-specific library, like devel/ncurses, and can be built on any platform.
(I don't see a warning using "port lint --nitpick").

In pkgsrc, a maintainer suggested that I rename "cdk-perl" to "p5-cdk".
I had considered it before, but it appeared that the p5-XXX's here were part of the perl distribution.
Should I do that now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants