Make MIDI device detection more robust #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. Thanks for this fix. With this, will it work if there is more than one device connected (maybe of a different type?) It seems to go for the first device no matter what. |
|
I'm not sure how it behaves with multiple devices, I didn't test that. Before this change, the assumption is that all devices use the same (pre-defined) midi device name ("Launchpad Mini") and port ("Launchpad Mini" as well). The second assumption didn't hold. This change effectively means that all devices only use the same pre-defined name ("Launchpad Mini"), and use the same port as the first device. |
rrrnld
force-pushed
the
repair/midi-device-detection
branch
from
8143e98 to
190cd44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code to set up the midi device breaks for me with the following error:
I'm on NixOS, my launchpad mini shows up in SC as
MIDIEndPoint("Launchpad Mini", "Launchpad Mini MIDI 1", 1310720). There may be differences between different OSes? This patch tries to make the setup logic a bit more robust.