Skip to content

Conversation

brandonbishopp
Copy link

Description (*)

Typecast product type data to stringify null values

Manual testing scenarios (*)

  1. Place an order
  2. Manually set an order item product type value to null
  3. Observe sales_order_clean exception

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pykettk
Copy link
Member

pykettk commented Apr 24, 2023

@brandon-1999 Don't forget to sign the CLA so we can get this moving 🙂

@brandonbishopp
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants