-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Minimal Next.js Example with Web Push Button #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it does seem to work! It's much simpler than the code it intends to replace, which is a good thing.
I'm concerned about completely overwriting the existing repo given how its relatively popular. It's removing a few things:
- the hacker news subscription, which judging by the logs, a few people seem to be making use of
- the new readme has removed the focus on ios (and the specific installation steps for ios), which i think is important given the repo name
- there were some quite detailed error states which detected relevant things about the user's device (e.g. visit https://webpushtest.com in an incognito browser) which are no longer present
@unamashana had the idea of a monorepo to contain lots of "quick setup" things like this. So I wonder if its best to add it there once it's created?
We could change the name of the repo or I could add the instructions for iOS.
I left out most of the things deliberately to make sure the code is simple and understandable. |
@niyabits @moxley01 I think the best path forward is to move with with an example app (starting with this button) in the https://github.com/magicbell/magicbell-js/tree/main/example repo. |
Thanks for the suggestions! :) |
Updates the repository with a minimal Web Push Example.