Skip to content

Conversation

niyabits
Copy link
Contributor

Updates the repository with a minimal Web Push Example.

@niyabits niyabits marked this pull request as ready for review July 17, 2025 13:13
@moxley01 moxley01 self-requested a review July 18, 2025 13:30
Copy link
Member

@moxley01 moxley01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and it does seem to work! It's much simpler than the code it intends to replace, which is a good thing.

I'm concerned about completely overwriting the existing repo given how its relatively popular. It's removing a few things:

  • the hacker news subscription, which judging by the logs, a few people seem to be making use of
  • the new readme has removed the focus on ios (and the specific installation steps for ios), which i think is important given the repo name
  • there were some quite detailed error states which detected relevant things about the user's device (e.g. visit https://webpushtest.com in an incognito browser) which are no longer present

@unamashana had the idea of a monorepo to contain lots of "quick setup" things like this. So I wonder if its best to add it there once it's created?

@niyabits
Copy link
Contributor Author

niyabits commented Jul 23, 2025

@moxley01

the new readme has removed the focus on ios

We could change the name of the repo or I could add the instructions for iOS.
I have tested the repo on iOS and it's working perfectly.

there were some quite detailed error states which detected relevant things about the user's device

I left out most of the things deliberately to make sure the code is simple and understandable.

@unamashana
Copy link
Member

@niyabits @moxley01 I think the best path forward is to move with with an example app (starting with this button) in the https://github.com/magicbell/magicbell-js/tree/main/example repo.

@niyabits
Copy link
Contributor Author

Thanks for the suggestions! :)
I will make a PR in the magicbell-js with the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants