Skip to content

Conversation

taco-paco
Copy link

SDK modifiactions to support base layer action/intents

Copy link
Contributor

@GabrielePicco GabrielePicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!
Dependencies need to be removed or published in order to publish the SDK.

rust/Cargo.toml Outdated
@@ -28,6 +28,10 @@ ephemeral-rollups-sdk-attribute-delegate = { path = "delegate", version = "=0.2.
ephemeral-rollups-sdk-attribute-commit = { path = "commit-attribute", version = "=0.2.7" }
magic-domain-program = { version = "0.0.1" }

# Magicblock
magicblock-delegation-program = { git = "https://github.com/magicblock-labs/delegation-program.git", rev = "00d720", features = ["no-entrypoint"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't depend on github in order to publish the crate on crates.io (we could publish the other crate though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants