-
Notifications
You must be signed in to change notification settings - Fork 13
Base layer ix #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Base layer ix #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
Dependencies need to be removed or published in order to publish the SDK.
rust/Cargo.toml
Outdated
@@ -28,6 +28,10 @@ ephemeral-rollups-sdk-attribute-delegate = { path = "delegate", version = "=0.2. | |||
ephemeral-rollups-sdk-attribute-commit = { path = "commit-attribute", version = "=0.2.7" } | |||
magic-domain-program = { version = "0.0.1" } | |||
|
|||
# Magicblock | |||
magicblock-delegation-program = { git = "https://github.com/magicblock-labs/delegation-program.git", rev = "00d720", features = ["no-entrypoint"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't depend on github in order to publish the crate on crates.io (we could publish the other crate though)
SDK modifiactions to support base layer action/intents