Handle errors in shared object loading #1461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
force-pushed
the
failable-so-load
branch
from
ce29a93 to
3271f37
Compare
Member
Author
|
I'm not sure and can't test while not at home, but I think this might address the issue in #1431. |
avdgrinten
reviewed
Oct 26, 2025
| if(!result) { | ||
| if (verbose || stillSlightlyVerbose) | ||
| mlibc::infoLogger() << "rtld: failed to open " << name << frg::endlog; | ||
| frg::destruct(getAllocator(), object); |
Member
There was a problem hiding this comment.
This could return a unique_ptr<SharedObject> to avoid the need for manual frg::destruct.
| break; | ||
| auto rpathResult = processRpath(path); | ||
| if (rpathResult) { | ||
| res = trySharedObjectSetup(rpathResult.value().get<0>(), rpathResult.value().get<1>()); |
Member
There was a problem hiding this comment.
Doesn't it make more sense to propagate the error if the open succeeds and the load fails? Basically, why don't we handle this like in the last case?
Comment on lines
+358
to
+359
| if (rpathResult) | ||
| res = trySharedObjectSetup(rpathResult.value().get<0>(), rpathResult.value().get<1>()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to have the dynamic linker tolerate failures in opening a shared object, in which case it should continue going down its list of paths to find an appropriate shared object.
This can reasonably occur in the wild, as for instance RPATHs can point to broken shared objects. Alternatively, I have encountered the case on my machine (Fedora) where the first
libgcc_s.so.1found is actually for i386, which is rejected, and further down the list of library paths the x86_64libgcc_s.so.1is found.