Skip to content

ManeuverViewBinder: get rid of TransitionManager#go #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release-v2.20
Choose a base branch
from
Draft

ManeuverViewBinder: get rid of TransitionManager#go #7904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions libnavui-dropin/src/main/java/com/mapbox/navigation/dropin/maneuver/ManeuverViewBinder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package com.mapbox.navigation.dropin.maneuver

import android.transition.Scene
import android.transition.TransitionManager
import android.view.LayoutInflater
import android.view.ViewGroup
import com.mapbox.navigation.core.lifecycle.MapboxNavigationObserver
import com.mapbox.navigation.dropin.R
import com.mapbox.navigation.dropin.databinding.MapboxManeuverGuidanceLayoutBinding
import com.mapbox.navigation.dropin.internal.extensions.reloadOnChange
import com.mapbox.navigation.dropin.navigationview.NavigationViewContext
Expand All @@ -18,13 +16,11 @@ internal class ManeuverViewBinder(
) : UIBinder {

override fun bind(viewGroup: ViewGroup): MapboxNavigationObserver {
val scene = Scene.getSceneForLayout(
viewGroup,
R.layout.mapbox_maneuver_guidance_layout,
viewGroup.context
viewGroup.removeAllViews()
val binding = MapboxManeuverGuidanceLayoutBinding.inflate(
LayoutInflater.from(viewGroup.context),
viewGroup
)
TransitionManager.go(scene)
val binding = MapboxManeuverGuidanceLayoutBinding.bind(viewGroup)

return reloadOnChange(
context.mapStyleLoader.loadedMapStyle,
Expand Down
Loading