[Chore] Use ReactNode instead of ReactElement where applicable #10998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanarnault
changed the title
djhi
requested changes
Oct 22, 2025
There was a problem hiding this comment.
I think you missed the <Datagrid expand> prop as it takes a ReactNode too according to both the doc and JSDoc (https://github.com/marmelab/react-admin/pull/10998/files#diff-1458ac898ea2924cc9ba84a442d85a75980a77a4f53823799136600375603063R401)
| | `body` | Optional | `ReactNode` | `<Datagrid Body>` | The component used to render the body of the table. | | ||
| | `bulkActionButtons` | Optional | `ReactNode` | `<BulkDelete Button>` | The component used to render the bulk action buttons. | | ||
| | `empty` | Optional | `ReactNode` | `<Empty>` | The component used to render the empty table. | | ||
| | `expand` | Optional | `ReactElement` | | The component used to render the expand panel for each row. | |
There was a problem hiding this comment.
Suggested change
| | `expand` | Optional | `ReactElement` | | The component used to render the expand panel for each row. | | |
| | `expand` | Optional | `ReactNode` | | The component used to render the expand panel for each row. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10996
Problem
A lot of RA components expect a
ReactElementwhere aReactNodecould be used.Solution
Replace
ReactElementwithReactNodewhere applicable.How To Test
N/A
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.