Skip to content

Feature/tag texts #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2025
Merged

Feature/tag texts #1345

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf6e63e
Make tags produce separate mtext nodes for the delimiters around the tag
dpvc Aug 28, 2025
7545ae7
Update tags in ams and mathtools packages
dpvc Aug 28, 2025
2f26005
Update tests for change in tag output
dpvc Aug 29, 2025
0740675
Update mathtools tag example
dpvc Sep 4, 2025
c97db48
Update lock file
dpvc Sep 4, 2025
85abf0b
Make changes from PR review
dpvc Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testsuite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"dependencies": {
"@jest/globals": "^29.7.0",
"@mathjax/mathjax-bbm-font-extension": "0.4.2-beta.8",
"@mathjax/mathjax-bbm-font-extension": "^4.0.0",
"@types/jest": "^29.5.14",
"jest": "^29.7.0",
"ts-jest": "^29.3.4",
Expand Down
10 changes: 5 additions & 5 deletions testsuite/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 54 additions & 18 deletions testsuite/tests/input/tex/Ams.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,9 @@ describe('Ams Environments', () => {
<mlabeledtr data-latex-item="{2}" data-latex="{2}">
<mtd id="mjx-eqn:1">
<mpadded width="0" lspace="-1width">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mpadded>
</mtd>
<mtd></mtd>
Expand Down Expand Up @@ -1866,7 +1868,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" columnalign="right left" columnspacing="0em" rowspacing="3pt" data-break-align="bottom top" data-latex-item="{align}" data-latex="\\begin{align} a&amp;=b \\\\ c&amp;=d \\end{align}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand All @@ -1881,7 +1885,9 @@ describe('Ams Tagged Environments', () => {
</mlabeledtr>
<mlabeledtr>
<mtd id="mjx-eqn:2">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="c">c</mi>
Expand Down Expand Up @@ -1954,7 +1960,9 @@ describe('Ams Tagged Environments', () => {
</mtr>
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd columnalign="right">
<mi data-latex="c">c</mi>
Expand Down Expand Up @@ -2063,7 +2071,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" columnspacing="1em" rowspacing="3pt" data-break-align="middle" data-latex-item="{gather}" data-latex="\\begin{gather} a=b \\\\ c=d \\end{gather}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand All @@ -2073,7 +2083,9 @@ describe('Ams Tagged Environments', () => {
</mlabeledtr>
<mlabeledtr>
<mtd id="mjx-eqn:2">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="c">c</mi>
Expand Down Expand Up @@ -2121,7 +2133,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" columnalign="right left" columnspacing="0em" rowspacing="3pt" data-break-align="bottom top" data-latex-item="{alignat}" data-latex="\\begin{alignat}{2} a&amp;=b \\\\ c&amp;=d \\end{alignat}">
<mlabeledtr data-latex-item="{2}" data-latex="{2}">
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand All @@ -2136,7 +2150,9 @@ describe('Ams Tagged Environments', () => {
</mlabeledtr>
<mlabeledtr data-latex-item="{2}" data-latex="{2}">
<mtd id="mjx-eqn:2">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="c">c</mi>
Expand Down Expand Up @@ -2376,7 +2392,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" data-latex-item="{equation}" data-latex="\\begin{equation} a \\end{equation}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand Down Expand Up @@ -2407,7 +2425,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" columnalign="right center left" columnspacing="0em 0.278em" rowspacing="3pt" data-break-align="bottom middle top" data-latex-item="{eqnarray}" data-latex="\\begin{eqnarray} a &amp; = &amp; b\\\\ c &amp; = &amp; d \\end{eqnarray}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand All @@ -2424,7 +2444,9 @@ describe('Ams Tagged Environments', () => {
</mlabeledtr>
<mlabeledtr>
<mtd id="mjx-eqn:2">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="c">c</mi>
Expand Down Expand Up @@ -2493,7 +2515,9 @@ describe('Ams Tagged Environments', () => {
<mtable displaystyle="true" columnalign="right left" columnspacing="0em" rowspacing="3pt" data-break-align="bottom top" data-latex-item="{align}" data-latex="\\begin{align} a&amp;=b \\\\ &amp;=c \\notag \\end{align}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand Down Expand Up @@ -2531,7 +2555,9 @@ describe('Ams Tagged Environments', () => {
<mlabeledtr data-latex-item="{1}" data-latex="{1}">
<mtd id="mjx-eqn:1">
<mpadded width="0" lspace="-1width">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mpadded>
</mtd>
<mtd></mtd>
Expand Down Expand Up @@ -2583,7 +2609,9 @@ describe('Ams Tagged Environments', () => {
<mtable width="100%" displaystyle="true" columnalign="right left center right" columnspacing="0em" columnwidth="auto auto fit auto" rowspacing="3pt" data-break-align="bottom top middle bottom" data-width-includes-label="true" data-latex-item="{flalign}" data-latex="\\begin{flalign} a&amp;b &amp; \\end{flalign}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand Down Expand Up @@ -2692,7 +2720,9 @@ describe('Ams Tagged Environments Left', () => {
<mlabeledtr data-latex-item="{2}" data-latex="{2}">
<mtd id="mjx-eqn:1">
<mpadded width="0">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mpadded>
</mtd>
<mtd></mtd>
Expand Down Expand Up @@ -2725,7 +2755,9 @@ describe('Ams Tagged Environments Left', () => {
<mtable displaystyle="true" rowspacing=".5em" columnspacing="100%" width="100%" side="left" data-array-padding="1em 1em" data-width-includes-label="true" data-latex-item="{multline}" data-latex="\\begin{multline} a\\tag{1} \\end{multline}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd columnalign="left">
<mi data-latex="\\tag{1}">a</mi>
Expand All @@ -2752,13 +2784,17 @@ describe('Ams Tagged Environments Left', () => {
<mtable displaystyle="true" columnspacing="1em" rowspacing="3pt" data-break-align="middle" side="left" data-latex-item="{gather}" data-latex="\\begin{gather}\\begin{align} a &amp;= b \\end{align}\\end{gather}">
<mlabeledtr>
<mtd id="mjx-eqn:2">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mtable displaystyle="true" columnalign="right left" columnspacing="0em" rowspacing="3pt" data-break-align="bottom top" side="left" data-latex-item="{align}" data-latex="{align}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand Down
40 changes: 29 additions & 11 deletions testsuite/tests/input/tex/Base.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12482,7 +12482,9 @@ describe('Referencing', () => {
<mtable displaystyle="true" data-latex="a\\label{A}">
<mlabeledtr>
<mtd id="mjx-eqn:A">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{A}">a</mi>
Expand All @@ -12502,7 +12504,9 @@ describe('Referencing', () => {
<mtable displaystyle="true" data-latex="a\\label{}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{}">a</mi>
Expand All @@ -12522,15 +12526,19 @@ describe('Referencing', () => {
<mtable displaystyle="true" columnalign="right" columnspacing="" rowspacing="3pt" data-break-align="bottom" data-latex-item="{eqnarray}" data-latex="\\begin{eqnarray}a\\label{A}\\\\c\\label{B}\\end{eqnarray}">
<mlabeledtr>
<mtd id="mjx-eqn:A">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{A}">a</mi>
</mtd>
</mlabeledtr>
<mlabeledtr>
<mtd id="mjx-eqn:B">
<mtext data-latex="\\text{(2)}">(2)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{2}">2</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{B}">c</mi>
Expand Down Expand Up @@ -12564,7 +12572,9 @@ describe('Referencing', () => {
<mtable displaystyle="true" data-latex="a\\label{A}\\ref{A}">
<mlabeledtr>
<mtd id="mjx-eqn:A">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{A}">a</mi>
Expand All @@ -12587,7 +12597,9 @@ describe('Referencing', () => {
<mtable displaystyle="true" data-latex="a\\label{A}\\ref{B}">
<mlabeledtr>
<mtd id="mjx-eqn:A">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="\\label{A}">a</mi>
Expand All @@ -12610,7 +12622,9 @@ describe('Referencing', () => {
<mtable displaystyle="true" columnalign="right" columnspacing="" rowspacing="3pt" data-break-align="bottom" data-latex-item="{eqnarray}" data-latex="\\begin{eqnarray}a\\\\c\\nonumber\\end{eqnarray}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand Down Expand Up @@ -14121,7 +14135,7 @@ describe('User Defined Environments', () => {
it('Cases star', () => {
toXmlMatch(
tex2mml('\\begin{mmtool} a & test a\\\\ b & test b \\end{mmtool}'),
`<math xmlns=\"http://www.w3.org/1998/Math/MathML\" data-latex=\"\\begin{mmtool} a &amp; test a\\\\ b &amp; test b \\end{mmtool}\" display=\"block\">
`<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{mmtool} a &amp; test a\\\\ b &amp; test b \\end{mmtool}" display="block">
<mrow data-mjx-texclass="INNER" data-latex-item="{mmtool}" data-latex="\\begin{mmtool} a &amp; test a\\\\ b &amp; test b \\end{mmtool}">
<mo data-mjx-texclass="OPEN">{</mo>
<mtable rowspacing=".2em" columnspacing="1em" columnalign="left">
Expand Down Expand Up @@ -14185,11 +14199,13 @@ describe('Tagged Environments', () => {
it('EqnTest', () => {
toXmlMatch(
tex2mml('\\begin{eqntest} a & b \\end{eqntest}'),
`<math xmlns=\"http://www.w3.org/1998/Math/MathML\" data-latex=\"\\begin{eqntest} a &amp; b \\end{eqntest}\" display=\"block\">
`<math xmlns="http://www.w3.org/1998/Math/MathML" data-latex="\\begin{eqntest} a &amp; b \\end{eqntest}" display="block">
<mtable displaystyle="true" columnalign="right left" columnspacing="1em" rowspacing="3pt" data-break-align="bottom top" data-latex-item="{eqntest}" data-latex="\\begin{eqntest} a &amp; b \\end{eqntest}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="a">a</mi>
Expand All @@ -14214,7 +14230,9 @@ describe('Tagged Environments', () => {
<mtable displaystyle="true" data-latex-item="{equation}" data-latex="\\begin{equation} x \\end{equation}">
<mlabeledtr>
<mtd id="mjx-eqn:1">
<mtext data-latex="\\text{(1)}">(1)</mtext>
<mtext data-latex="\\text{(}">(</mtext>
<mtext data-latex="\\text{1}">1</mtext>
<mtext data-latex="\\text{)}">)</mtext>
</mtd>
<mtd>
<mi data-latex="x">x</mi>
Expand Down
Loading