Test that invites can be rescinded over federation #797
Conversation
|
Very sensible, I'm surprised we didn't! |
Co-authored-by: Eric Eastwood <erice@element.io>
Co-authored-by: Eric Eastwood <erice@element.io>
| "invite": []string{bob.UserID}, | ||
| }) | ||
| bob.MustSyncUntil(t, client.SyncReq{}, client.SyncInvitedTo(bob.UserID, roomID)) | ||
| alice.MustDo(t, "POST", []string{"_matrix", "client", "v3", "rooms", roomID, "kick"}, |
There was a problem hiding this comment.
It would be good to have a test where someone else rescinds the invite (someone different than the inviter)
Also a test for someone else from another server in the room
There was a problem hiding this comment.
Test was added for the first case but not the second for someone else from another server in the room
| bob.MustSyncUntil(t, client.SyncReq{Filter: includeLeaveSyncFilter}, client.SyncLeftFrom(bob.UserID, roomID)) | ||
| }) | ||
|
|
||
| t.Run("Non-invitee user cannot rescind invite over federation", func(t *testing.T) { |
There was a problem hiding this comment.
| t.Run("Non-invitee user cannot rescind invite over federation", func(t *testing.T) { | |
| t.Run("Non-inviter user cannot rescind invite over federation", func(t *testing.T) { |
| // Alice, not the original inviter, kicks bob. This does not result | ||
| // in bob seeing the rescission. |
There was a problem hiding this comment.
We should comment that it would be fine for bob to see the rescission but they have no way to auth it because of X so they can't take it into account
| "invite": []string{bob.UserID}, | ||
| }) | ||
| bob.MustSyncUntil(t, client.SyncReq{}, client.SyncInvitedTo(bob.UserID, roomID)) | ||
| alice.MustDo(t, "POST", []string{"_matrix", "client", "v3", "rooms", roomID, "kick"}, |
There was a problem hiding this comment.
Test was added for the first case but not the second for someone else from another server in the room
c.f. element-hq/synapse#18823