Skip to content

Conversation

@ngoyal16
Copy link

No description provided.

@maurice2k
Copy link
Owner

maurice2k commented Nov 11, 2022

Thanks for the fix!
Looks like this completely fall out while optimizing. I think adding a .Add()/.Done() call in that function will probably hurt performance a lot. Maybe we can do something with activeConnections....
Or we just do the .Add() and .Done() calls only if activeConnections == 1 and 0 respectively?

@ngoyal16
Copy link
Author

@maurice2k what if there are lots of activeConnection and someone call shutdown. how single Add and Done will work in that case.

@ngoyal16
Copy link
Author

@maurice2k any update on same?

@Tochemey
Copy link

@maurice2k any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants