docs: updated documentation for MVC component. #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Teebarh please take a look at the failing build job. It gives you some insights into why you cannot see the MVC item on the menu. |
|
Okay, I'll give it a look. |
|
Hi @Teebarh please review the feedback from @escopecz in the commit here: 5b0b900#r158199455 As I mentioned, this whole section needed to be reviewed and updated while reviewing the Mautic codebase, because we use Twig now instead of PHP views, and a whole lot of stuff has changed (e.g. using dependency injection). So this PR needs to be updated to consider that, and provide the appropriate documentation accordingly. |
|
I'll check it out and revert back accordingly. Thank you, Ruth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings over the documentation for the MVC component, updates it to include new additions, and converts the format to reStructuredText (RST).
It addresses issue #99.