Skip to content

Context menu improvements #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Context menu improvements #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Sources/TableDirector.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,34 @@ open class TableDirector: NSObject, UITableViewDataSource, UITableViewDelegate {
{
invoke(action: .showContextMenu, cell: tableView.cellForRow(at: indexPath), indexPath: indexPath, userInfo: [TableKitUserInfoKeys.ContextMenuInvokePoint: point]) as? UIContextMenuConfiguration
}

@available(iOS 13.0, *)
open func tableView(_ tableView: UITableView,
previewForHighlightingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview? {

if let indexPath = configuration.identifier as? IndexPath {

return invoke(action: .previewForHighlightingContextMenu,
cell: tableView.cellForRow(at: indexPath),
indexPath: indexPath,
userInfo: [TableKitUserInfoKeys.ContextMenuConfiguration: configuration]) as? UITargetedPreview
}
return nil
}

@available(iOS 13.0, *)
open func tableView(_ tableView: UITableView,
previewForDismissingContextMenuWithConfiguration configuration: UIContextMenuConfiguration) -> UITargetedPreview? {

if let indexPath = configuration.identifier as? IndexPath {

return invoke(action: .previewForDismissingContextMenu,
cell: tableView.cellForRow(at: indexPath),
indexPath: indexPath,
userInfo: [TableKitUserInfoKeys.ContextMenuConfiguration: configuration]) as? UITargetedPreview
}
return nil
}

// MARK: - Row editing
open func tableView(_ tableView: UITableView, canEditRowAt indexPath: IndexPath) -> Bool {
Expand Down
3 changes: 3 additions & 0 deletions Sources/TableKit.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public struct TableKitUserInfoKeys {
public static let CellMoveDestinationIndexPath = "TableKitCellMoveDestinationIndexPath"
public static let CellCanMoveProposedIndexPath = "CellCanMoveProposedIndexPath"
public static let ContextMenuInvokePoint = "ContextMenuInvokePoint"
public static let ContextMenuConfiguration = "ContextMenuConfiguration"
}

public protocol RowConfigurable {
Expand Down Expand Up @@ -84,6 +85,8 @@ public enum TableRowActionType {
case canMoveTo
case move
case showContextMenu
case previewForHighlightingContextMenu
case previewForDismissingContextMenu
case accessoryButtonTap
case custom(String)

Expand Down