refactor: trip planner widget using new form input #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: TP Cleanup | Update location search results display for Trip Planner home tab
Bonus Asana Ticket: TP Cleanup | Update widget location search results, URL redirection
Tip
The trip planner in the homepage tab and the form shown in the sidebar of many pages (listed in the second ticket) are based off the same template, so all of these got updated in one go.
algolia-autocompletePhoenix hook needed a change to make the form work outside of LiveView. Instead of only relying on the LiveViewinput_form_changeevent to update the underlying lat/lon/name/stop for each location, I've added some JS to update the form field values directly.Dotcom.TripPlan.AntiCorruptionLayerneeded a change to handle the particular URL parameters sent from the submission of the widget form (they're slightly different than the old ones).