fix: make play.meshery.io vendor neutral #254
Conversation
Signed-off-by: FaheemOnHub <faheemmushtaq89@gmail.com>
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @FaheemOnHub, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the play.meshery.io site by making the playground selection process vendor-neutral. It replaces a direct link with an interactive modal that presents users with choices for Meshery Playground vendors, thereby improving the site's extensibility and user experience.
Highlights
- Vendor Neutrality: The 'Open Playground' call-to-action has been replaced with a 'Choose Your Playground' button, which now triggers a modal for vendor selection, moving away from a hardcoded, single-vendor experience.
- New Vendor Selection UI: A new
VendorSelectioncomponent has been introduced. This component provides a user interface within a modal, allowing users to select from available Meshery Playground vendors (currently Layer5) and offering an option to 'Add Your Own Vendor' with a link to relevant documentation. - UI/UX Refinements: Minor textual adjustments were made to the hero section's title and description. The modal's content label was updated, and the
Faqcomponent's categories within the modal were expanded. Styling adjustments were also made to theFaqsection to better accommodate the new modal content.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
add your own provider goes to: https://docs.meshery.io/extensibility/providers |
There was a problem hiding this comment.
Code Review
This pull request refactors the playground access flow by replacing a direct link with a modal for vendor selection, enhancing vendor neutrality. The changes introduce a new VendorSelection component and update the App component to integrate this modal. The review focuses on code quality, JSX validity, React best practices for keys, and styling improvements for maintainability and consistency.
|
@Namanv0509 kindly review this && if you want to make changes make them. |
|
@FaheemOnHub Sure , i will have a look . |
Signed-off-by: FaheemOnHub <faheemmushtaq89@gmail.com>
3 participants
Notes for Reviewers
replacing hardcoded “Open Playground” CTA with "Choose Your Playground"
modal-based vendor selection screen
Signed commits