-
Notifications
You must be signed in to change notification settings - Fork 118
Fix: Update discussion forum URL to correct domain #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update discussion forum URL to correct domain #270
Conversation
❌ Deploy Preview for meshery-play failed.
|
Summary of ChangesHello @shri33, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue by updating an outdated and broken link to the project's discussion forum. The change ensures that users attempting to access the community forum are correctly redirected to the active and secure platform, thereby improving user experience and facilitating easier access to community discussions and support. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the discussion forum URL. I've added one suggestion to improve the user experience and security by opening this external link in a new tab with the appropriate rel attributes.
051dde8 to
3b5f823
Compare
- Changed from http://discuss.meshery.io/ to https://discuss.layer5.io/ - Fixes broken link in 'Join the Conversation' section - Resolves meshery/meshery#16152 Signed-off-by: shri33 <your-email@example.com>
3b5f823 to
07a9183
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Shri Srivastava <76124911+shri33@users.noreply.github.com>
|
Also add this issue in your commit |
|
@shri33 thanks for fix |
Signed-off-by: Rian the rizzler <182301570+ritzorama@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notes for Reviewers
This PR fixes #
Signed commits