Variable for %GPS in quick chat. Feature request #2653

.claude/settings.local.json

@@ -0,0 +1,28 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(dir)",
+      "Bash(git clone https://github.com/meshtastic/Meshtastic-Android.git .)",
+      "Bash(git submodule update --init --recursive)",
+      "Bash(where sdkmanager)",
+      "Bash(echo $ANDROID_HOME)",
+      "Bash(./gradlew --version)",
+      "Bash(./gradlew assembleDebug)",
+      "Bash(where java)",
+      "Bash(\"C:\\Program Files\\Android\\Android Studio\\jbr\\bin\\java.exe\" -version)",
+      "Bash($env:JAVA_HOME=\"C:\\Program Files\\Android\\Android Studio\\jbr\")",
+      "Bash(export JAVA_HOME=\"C:/Program Files/Android/Android Studio/jbr\")",
+      "Read(//c/Users/**)",
+      "Bash(./gradlew :feature:messaging:assembleDebug)",
+      "Bash(./gradlew assembleFdroidDebug)",
+      "Bash(./gradlew assembleGoogleDebug)",
+      "Bash(./gradlew clean)",
+      "Bash(./gradlew :app:assembleFdroidDebug)",
+      "Bash(./gradlew clean assembleFdroidDebug)",
+      "Bash(./gradlew :app:assembleFdroidDebug --rerun-tasks)",
+      "Bash(./gradlew :app:assembleGoogleDebug)"
+    ],
+    "deny": [],
+    "ask": []
+  }
+}

feature/messaging/detekt-baseline.xml

@@ -15,7 +15,7 @@
     <ID>LambdaParameterEventTrailing:MessageList.kt$onReply</ID>
     <ID>LambdaParameterEventTrailing:QuickChat.kt$onNavigateUp</ID>
     <ID>LambdaParameterInRestartableEffect:MessageList.kt$onUnreadChanged</ID>
-    <ID>LongParameterList:MessageViewModel.kt$MessageViewModel$( private val nodeRepository: NodeRepository, radioConfigRepository: RadioConfigRepository, quickChatActionRepository: QuickChatActionRepository, private val serviceRepository: ServiceRepository, private val packetRepository: PacketRepository, private val uiPrefs: UiPrefs, private val meshServiceNotifications: MeshServiceNotifications, )</ID>
+    <ID>LongParameterList:MessageViewModel.kt$MessageViewModel$( private val nodeRepository: NodeRepository, radioConfigRepository: RadioConfigRepository, private val quickChatActionRepository: QuickChatActionRepository, private val serviceRepository: ServiceRepository, private val packetRepository: PacketRepository, private val uiPrefs: UiPrefs, private val meshServiceNotifications: MeshServiceNotifications, )</ID>
     <ID>ModifierMissing:Message.kt$MessageScreen</ID>
     <ID>ModifierNotUsedAtRoot:QuickChat.kt$modifier = modifier.fillMaxSize().padding(innerPadding)</ID>
     <ID>MutableStateParam:MessageList.kt$selectedIds</ID>

feature/messaging/src/main/kotlin/org/meshtastic/feature/messaging/Message.kt

@@ -303,6 +303,8 @@ fun MessageScreen(
                         handleQuickChatAction(
                             action = action,
                             messageInputState = messageInputState,
+                            userLatitude = ourNode?.takeIf { it.validPosition != null }?.latitude,
+                            userLongitude = ourNode?.takeIf { it.validPosition != null }?.longitude,
                             onSendMessage = { text -> onEvent(MessageScreenEvent.SendMessage(text)) },
                         )
                     },
@@ -422,25 +424,37 @@ private fun String.ellipsize(maxLength: Int): String = if (length > maxLength) "
  *
  * @param action The [QuickChatAction] to handle.
  * @param messageInputState The [TextFieldState] of the message input field.
+ * @param userLatitude Current user latitude, if available.
+ * @param userLongitude Current user longitude, if available.
  * @param onSendMessage Lambda to call when a message needs to be sent.
  */
 private fun handleQuickChatAction(
     action: QuickChatAction,
     messageInputState: TextFieldState,
+    userLatitude: Double?,
+    userLongitude: Double?,
     onSendMessage: (String) -> Unit,
 ) {
+    val processedMessage =
+        if (userLatitude != null && userLongitude != null) {
+            val gpsString = "%.7f,%.7f".format(userLatitude, userLongitude)
+            action.message.replace("%GPS", gpsString, ignoreCase = true)
+        } else {
+            action.message
+        }
+
     when (action.mode) {
         QuickChatAction.Mode.Append -> {
             val originalText = messageInputState.text.toString()
             // Avoid appending if the exact message is already present (simple check)
-            if (!originalText.contains(action.message)) {
+            if (!originalText.contains(processedMessage)) {
                 val newText =
                     buildString {
                         append(originalText)
                         if (originalText.isNotEmpty() && !originalText.endsWith(' ')) {
                             append(' ')
                         }
-                        append(action.message)
+                        append(processedMessage)
                     }
                         .limitBytes(MESSAGE_CHARACTER_LIMIT_BYTES)
                 messageInputState.setTextAndPlaceCursorAtEnd(newText)
@@ -449,7 +463,7 @@ private fun handleQuickChatAction(
 
         QuickChatAction.Mode.Instant -> {
             // Byte limit for 'Send' mode messages is handled by the backend/transport layer.
-            onSendMessage(action.message)
+            onSendMessage(processedMessage)
         }
     }
 }
@@ -707,7 +721,7 @@ private fun QuickChatRow(
     val allActions = remember(alertAction, actions) { listOf(alertAction) + actions }
 
     LazyRow(modifier = modifier.padding(vertical = 4.dp), horizontalArrangement = Arrangement.spacedBy(4.dp)) {
-        items(allActions, key = { it.uuid }) { action ->
+        items(allActions, key = { it.position }) { action ->
             Button(onClick = { onClick(action) }, enabled = enabled) { Text(text = action.name) }
         }
     }

feature/messaging/src/main/kotlin/org/meshtastic/feature/messaging/MessageViewModel.kt

@@ -55,7 +55,7 @@ class MessageViewModel
 constructor(
     private val nodeRepository: NodeRepository,
     radioConfigRepository: RadioConfigRepository,
-    quickChatActionRepository: QuickChatActionRepository,
+    private val quickChatActionRepository: QuickChatActionRepository,
     private val serviceRepository: ServiceRepository,
     private val packetRepository: PacketRepository,
     private val uiPrefs: UiPrefs,
@@ -77,6 +77,26 @@ constructor(
 
     val quickChatActions = quickChatActionRepository.getAllActions().stateInWhileSubscribed(initialValue = emptyList())
 
+    init {
+        viewModelScope.launch(Dispatchers.IO) {
+            val actions = quickChatActionRepository.getAllActions()
+            var isEmpty = true
+            actions.collect { list ->
+                if (isEmpty && list.isEmpty()) {
+                    quickChatActionRepository.upsert(
+                        org.meshtastic.core.database.entity.QuickChatAction(
+                            name = "📍",
+                            message = "https://maps.google.com/?q=%GPS",
+                            mode = org.meshtastic.core.database.entity.QuickChatAction.Mode.Append,
+                            position = 0,
+                        ),
+                    )
+                }
+                isEmpty = false
+            }
+        }
+    }
+
     private val contactKeyForMessages: MutableStateFlow<String?> = MutableStateFlow(null)
     private val messagesForContactKey: StateFlow<List<Message>> =
         contactKeyForMessages