fix: address backfill issue on tcp connections; add logging #3676
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3676 +/- ##
========================================
+ Coverage 0.51% 0.56% +0.05%
========================================
Files 377 377
Lines 21298 21449 +151
Branches 2580 2622 +42
========================================
+ Hits 109 122 +13
- Misses 21169 21307 +138
Partials 20 20 ☔ View full report in Codecov by Sentry. |
mdecourcy
force-pushed
the
fix/tcp-backfill-regression
branch
2 times, most recently
from
2fde6b9 to
e2bd4e6
Compare
mdecourcy
changed the title
mdecourcy
force-pushed
the
fix/tcp-backfill-regression
branch
from
a99fb61 to
3668f93
Compare
mdecourcy
force-pushed
the
fix/tcp-backfill-regression
branch
from
3668f93 to
24729ba
Compare
jamesarich
left a comment
jamesarich
left a comment
There was a problem hiding this comment.
looks like the rebase munged a few of the things implemented in #3691
|
|
||
| PayloadVariantCase.LOG_RECORD -> { proto: MeshProtos.FromRadio -> handleLogRecord(proto.logRecord) } | ||
| PayloadVariantCase.LOG_RECORD -> { proto: MeshProtos.FromRadio -> handleLogReord(proto.logRecord) } | ||
|
|
There was a problem hiding this comment.
oop looks like you undid my typo fix... and some of the logging I had added in #3691 for the bt connection, mind giving it another pass?
There was a problem hiding this comment.
My bad yeah i was in rebase hell for a bit there. On it
There was a problem hiding this comment.
When it gets too bad, cherrypicking the other way onto a new branch is often easier
…htastic#3691) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
3 participants
This PR ensures the Android client always asks the radio for its buffered text messages after a disconnect/reconnect and captures the responses. We now persist the last StoreForward replay marker per device, issue a CLIENT_HISTORY request (and restart the RX collector) as soon as any transport returns to CONNECTED, and ship focused debug logs/tests. That brings Wi‑Fi/TCP reconnects back in line with BLE/2.7.5, so queued messages are delivered again.
To close #3672
big thanks to @dblaber / corruptedstack on discord for helping verify! My heltec just came in and I have also verified.