-
-
Notifications
You must be signed in to change notification settings - Fork 341
feat: tapping new node seen notification opens node detail page #3684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: tapping new node seen notification opens node detail page #3684
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
========================================
- Coverage 0.51% 0.51% -0.01%
========================================
Files 374 377 +3
Lines 21159 21328 +169
Branches 2538 2588 +50
========================================
Hits 109 109
- Misses 21030 21199 +169
Partials 20 20 ☔ View full report in Codecov by Sentry. |
jamesarich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdecourcy - we've already got deeplink routes defined in navigation.. we should be handling this similarly to how we're currently navigating to the correct Conversation from the message notif.
DaneEvans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me once James' happy
| val topLevelDestination = TopLevelDestination.fromNavDestination(currentDestination) | ||
|
|
||
| // Handle pending deep links (e.g., from notifications) once NavHost is ready | ||
| LaunchedEffect(pendingDeepLink) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current message notification routes to the message screen appropriately without this, using the Navigation sdk deeplinking that's already in place. Why do we need additional handling here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly wasnt able to get it working without the extra handling, just kept opening the node lsit. I can take another stab at it later today when I'm at the airport
meshtastic://meshtastic/node/{destNum}to the notification PendingIntent./node/{destNum}and navigates toNodesRoutes.NodeDetailGraph(destNum)so ViewModels receive the param.