Skip to content

Conversation

hvaria
Copy link

@hvaria hvaria commented Mar 12, 2024

…them and remapping their keys

Integrating loading, merging, and remapping into one step reduces the overall processing time by minimizing redundant operations. Pre-compiling the regular expression used for identifying and transforming layer-related keys cuts down the processing time required for these operations. By directly updating the final results without an intermediate merged dictionary, the memory footprint is reduced.

…them and remapping their keys

Integrating loading, merging, and remapping into one step reduces the overall processing time by minimizing redundant operations.
Pre-compiling the regular expression used for identifying and transforming layer-related keys cuts down the processing time required for these operations.
By directly updating the final results without an intermediate merged dictionary, the memory footprint is reduced.
@facebook-github-bot
Copy link

Hi @hvaria!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants