: logging: include pid in create_file_writer #892
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80349615 |
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Differential Revision: D80349615
shayne-fletcher
force-pushed
the
export-D80349615
branch
from
143ace7 to
44cdcd8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80349615 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 15, 2025
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Differential Revision: D80349615
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 15, 2025
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Differential Revision: D80349615
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 15, 2025
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Differential Revision: D80349615
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 15, 2025
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Differential Revision: D80349615
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Aug 17, 2025
Summary: `fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_test` is a standalone self bootstrapping program that uses `ProcessAllocator` to do the following: - the driver creates a proc/process to host a `ProxyActor` - initialization of the `ProxyActor` on the new proc/process creates a proc/process to host a `TestActor` so, executing this program creates a 3 level process hierarchy `driver -> parent -> grandchild` where the `parent` process hosts a single proc/process (rank = 0) with one `ProxyActor` and the `grandchild` a single proc/process (rank = 0) with one `TestActor`. using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file `/tmp/$USER/monarch_log_0.stdout`. this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name. so, for example, now there will be logs `monarch_log_3529266_0.stdout` (capturing the logs of the parent proc) and `monarch_log_3530444_0.stdout` (capturing the logs of the grandchild proc). Reviewed By: highker Differential Revision: D80349615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fbcode//monarch/hyperactor_mesh:hyperactor_mesh_proxy_testis a standalone self bootstrapping program that usesProcessAllocatorto do the following:ProxyActorProxyActoron the new proc/process creates a proc/process to host aTestActorso, executing this program creates a 3 level process hierarchy
driver -> parent -> grandchildwhere theparentprocess hosts a single proc (rank = 0) with oneProxyActorand thegrandchilda single proc/process with a single proc (rank = 0).using this program, i observe that as things stand, logs from the parent and the grandchild (since they share a common rank) are merged in the one file
/tmp/$USER/monarch_log_0.stdout.this diff disambiguates proc logs by incorporating the process ID of the mesh owner into the proc's log file name.
so, for example, now there will be logs
monarch_log_3529266_0.stdout(capturing the logs of the parent proc) andmonarch_log_3530444_0.stdout(capturing the logs of the grandchild proc).Differential Revision: D80349615