Fixing device inconsistency issues when fixing the composition weights manually #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How lame of me -- I did not see @bananenpampe 's PR below (#502), sorry. I leave things up to the devs to ignore this PR at their own will, provided that #502 takes care of the issues described here sufficiently. |
|
addressed by #514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug when trying to fix the composition weights manually with the provided feature, where values, samples, and properties were residing in different devices. I have enforced them to be stored on the same device so that the feature works again. Tested for
SOAP-BPNNarchitecture.Contributor (creator of pull-request) checklist
Reviewer checklist
📚 Documentation preview 📚: https://metatrain--513.org.readthedocs.build/en/513/