Refactor pet #662
Draft
Refactor pet #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f mask; trying to improve readability of the architecture. test_compatibility.py: remap checkpoint keys for compatibility with new structure of transfomer.py; module.py: created a few private helpers to make the __init__ more readable.
|
Currently not torchscriptable, working on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the native PET code to be more readable and documented, while tracking the back compatibility with previous models' checkpoints.
The main changes so far are:
Creation of the TokenEncoder.py class to factorize the logic behind the creation of new tokens from edges, distances and input messages.
Several functionality have been pushed into private helpers, to make the init and the forward pass more readable. The helpers require further testing to ensure that all the functionalities are torch scriptable.
TODO
📚 Documentation preview 📚: https://metatrain--662.org.readthedocs.build/en/662/