-
Notifications
You must be signed in to change notification settings - Fork 6
Service resolution fixed, tailscale update #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valentinalexeev
wants to merge
71
commits into
mewil:main
Choose a base branch
from
valentinalexeev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case parameters other than the host name itself were changed the controller would not pick up the update. With this change we pay attention to the generation attribute and recreate the Tailscale host if anything was update (i.e. TLS, Funnel, path specifications)
Similar to ingress-nginx implement pure TCP proxies with ConfigMap setup Controller code requires refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Michael, hi! Thank you for your work! It is the last missing piece for me to prepare for the move from my old Docker Compose-based setup into the shiny new K8s world.
I've decided to fix/update some of the things I found:
Please feel free to change or comment.