Skip to content

System value tuple net462 only #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

DerAtro
Copy link
Contributor

@DerAtro DerAtro commented Apr 21, 2025

  • Defined System.ValueTuple package reference as conditional for net462 only to reduce package references for other TFMs
  • Removed the net46 conditional references to System and Microsoft.CSharp as they are both included by SDK and net46 condition is always false with the current TFMs

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (c066b4f) to head (54e6e62).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files           6        6           
  Lines         848      848           
  Branches       92       92           
=======================================
  Hits          803      803           
  Misses         34       34           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mganss mganss merged commit 8982b6b into mganss:master Apr 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants