Fedora 43 fix

[meeuw]

I got a failure when installing davmail on Fedora 43, %service_add_post is suse specific.

[esabol]

Déjà vu! PR #421 was just closed recently...

[mguessan]

Can you please confirm latest copr package is working for you?

[meeuw]

I just tried the latest copr package (6.5.1-2.1) and it fails with the following error:

>>> Running %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                                     
>>> Non-critical error in %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                       
>>> Scriptlet output:                                                                                                                                                                       
>>> /var/tmp/rpm-tmp.CKjqcP: line 9: fg: no job control                                                                                                                                     
>>>                                                                                                                                                                                         
>>> [RPM] %post(davmail-6.5.1-2.1.noarch) scriptlet failed, exit status 1                                                                                                                   

Due to:

# rpm -q davmail --scripts
postinstall scriptlet (using /bin/sh):
file=/var/log/davmail.log
if [ ! -f ${file} ]
    then
    /bin/touch ${file}
fi
/bin/chown davmail:davmail ${file}
/bin/chmod 0640 ${file}

%service_add_post davmail.service
^^^

You can easily test this using docker:

$ docker run --rm -ti fedora:43 
...
bash-5.3# dnf copr enable mguessan/davmail
...
Is this ok [y/N]: y
...
bash-5.3# dnf install davmail
...
Is this ok [y/N]: y
...
Is this ok [y/N]: y
...
[292/317] Installing davmail-0:6.5.1-2.1.noarch                                                                                                     100% | 185.9 MiB/s |   7.1 MiB |  00m00s
>>> Running %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                                     
>>> Non-critical error in %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                       
>>> Scriptlet output:                                                                                                                                                                       
>>> /var/tmp/rpm-tmp.avdRqm: line 9: fg: no job control                                                                                                                                     
>>>                                                                                                                                                                                         
>>> [RPM] %post(davmail-6.5.1-2.1.noarch) scriptlet failed, exit status 1                                                                                                                   
...

There are a lot of errors output so it might be easier to re-run dnf by reinstalling davmail:

bash-5.3# dnf reinstall davmail
Updating and loading repositories:
Repositories loaded.
Package                                                   Arch     Version                                                   Repository                                                 Size
Reinstalling:
 davmail                                                  noarch   6.5.1-2.1                                                 copr:copr.fedorainfracloud.org:mguessan:davmail         7.1 MiB
   replacing davmail                                      noarch   6.5.1-2.1                                                 <unknown>                                               7.1 MiB

Transaction Summary:
 Reinstalling:       1 package
 Replacing:          1 package

Total size of inbound packages is 6 MiB. Need to download 0 B.
After this operation, 0 B extra will be used (install 7 MiB, remove 7 MiB).
Is this ok [y/N]: y
[1/1] davmail-0:6.5.1-2.1.noarch                                                                                                                    100% |   0.0   B/s |   0.0   B |  00m00s
>>> Already downloaded                                                                                                                                                                      
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[1/1] Total                                                                                                                                         100% |   0.0   B/s |   0.0   B |  00m00s
Running transaction
[1/4] Verify package files                                                                                                                          100% |  50.0   B/s |   1.0   B |  00m00s
[2/4] Prepare transaction                                                                                                                           100% |  76.0   B/s |   2.0   B |  00m00s
[3/4] Reinstalling davmail-0:6.5.1-2.1.noarch                                                                                                       100% | 141.3 MiB/s |   7.1 MiB |  00m00s
>>> Running %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                                     
>>> Non-critical error in %post scriptlet: davmail-0:6.5.1-2.1.noarch                                                                                                                       
>>> Scriptlet output:                                                                                                                                                                       
>>> /var/tmp/rpm-tmp.UWghAy: line 9: fg: no job control                                                                                                                                     
>>>                                                                                                                                                                                         
>>> [RPM] %post(davmail-6.5.1-2.1.noarch) scriptlet failed, exit status 1                                                                                                                   
[4/4] Removing davmail-0:6.5.1-2.1.noarch                                                                                                           100% | 333.0   B/s |  33.0   B |  00m00s
Transaction failed: Rpm transaction failed.

The patch in this PR should fix this.

[mguessan]

Patch merged, thanks for your contribution