Fixes potential duplicate operation ids of navigation property paths with overloaded composable functions #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irvinesunday
requested review from
andrueastman,
danielmbaluka,
darrelmiller,
gavinbarron,
millicentachieng and
xuzhg
as code owners
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
Just a suggestion. Otherwise looks good from my end.
I believe to fix the sonar coverage reporting you will need to update this line to end with coverage.net8.0.opencover.xml as the net7.0 coverage artifact no longer exists...
baywet
requested changes
Oct 17, 2024
Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com>
baywet
approved these changes
Oct 17, 2024
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
I'm a bit surprised we don't have to refresh the integration tests with those changes. But thanks for the quick turnaround on this one.
Member
|
@andrueastman thanks for the suggestion, quickly put #598 together |
|
andrueastman
approved these changes
Oct 17, 2024
andrueastman
added a commit
that referenced
this pull request
Jan 15, 2025
…with overloaded composable functions (#597) * Fixes generation of navigation property op ids with overloaded composable fxns * Adds validation unit test * Updates release note * chore: adds string comparison Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com> --------- Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com>
andrueastman
pushed a commit
that referenced
this pull request
Jan 15, 2025
…with overloaded composable functions (#597)
Merged
baywet
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596