Fix one of the sparse app (WPF) according to public doc #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Windows AI Foundry WPF sample to enable system AI model capabilities by adding the required manifest changes and project configuration updates as specified in the Windows AI documentation.
- Added
systemainamespace andsystemAIModelscapability to the app manifest - Updated
MaxVersionTestedto10.0.26226.0for Windows Insider build compatibility - Configured project to prevent automatic OS version replacement in manifest
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| WindowsAISampleForWPFSparse.csproj | Added properties to disable automatic manifest OS version replacement |
| AppxManifest.xml | Added systemai namespace, systemAIModels capability, and updated MaxVersionTested version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Samples/WindowsAIFoundry/cs-wpf-sparse/WindowsAISampleForWPF/WindowsAISampleForWPFSparse.csproj
Outdated
Show resolved
Hide resolved
Samples/WindowsAIFoundry/cs-wpf-sparse/WindowsAISampleForWPF/AppxManifest.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to https://learn.microsoft.com/en-us/windows/ai/apis/get-started?tabs=winget%2Cwinui%2Cwinui2, there are multiple changes before the AI API can be used.
This pull request updates the Windows AI Foundry WPF sample to support new system AI model capabilities and aligns the app manifest with the latest Windows versions. The most important changes are grouped below:
Manifest and Capability Updates:
systemainamespace and set it as ignorable inAppxManifest.xml, enabling the use of new system AI capabilities.systemAIModelscapability under the newsystemainamespace, allowing the app to access system-provided AI models.Platform and Compatibility Updates:
MaxVersionTestedfor theWindows.Desktoptarget device family to10.0.26226.0inAppxManifest.xml, ensuring compatibility with the latest Windows Insider builds.WindowsAISampleForWPFSparse.csproj) to prevent automatic replacement of manifest OS min/max versions, giving developers more control over versioning.Target Release
1.8