[Issue 5395] Fix msbuild warnings #5685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Aug 5, 2025
build/NuSpecs/WindowsAppSDK-Nuget-Native.AutoInitializer.targets
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Aug 13, 2025
Scottj1s
reviewed
Aug 13, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Aug 18, 2025
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <Target Name="WindowsAppRuntimeAutoInitializerPreprocessorDefinitions"> |
There was a problem hiding this comment.
nit: now that we understand root cause, we could simplify by calculating the preprocessor definitions in situ, like we do with GenerateUndockedRegFreeWinRTCpp
Scottj1s
approved these changes
Aug 18, 2025
ssparach
force-pushed
the
user/ssparach/fixBuildWarnings
branch
from
8635895 to
d418f2c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to fix the following msbuild warning:
warning MSB8027: Two or more files with the name of WindowsAppRuntimeAutoInitializer.cpp will produce outputs to the same location. This can lead to an incorrect build result.
This build warning seems to be caused by:
MSB4120: Item 'ClCompile' definition within target references itself via (qualified or unqualified) metadatum 'PreprocessorDefinitions'. This can lead to unintended expansion and cross-applying of pre-existing items. More info: https://aka.ms/msbuild/metadata-self-ref
This PR eliminates duplicate output by disabling MSBuild batching and applying PreProcessorDefinitions uniformly across all source files.
Testing
Confirmed that the warning no longer appears in the MSBuild binlog during repro testing.
Pipeline builds
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.