Skip to content

Fix: Catch TargetClosedError in PlaywrightController.sleep() to avoid crashes on download-triggered page closes #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Merge branch 'main' into fix/playwrightcontroller-sleep-targetclosed

aaa6233
Select commit
Loading
Failed to load commit list.
Open

Fix: Catch TargetClosedError in PlaywrightController.sleep() to avoid crashes on download-triggered page closes #6415

Merge branch 'main' into fix/playwrightcontroller-sleep-targetclosed
aaa6233
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 21, 2025 in 1s

60.00% of diff hit (target 79.52%)

View this Pull Request on Codecov

60.00% of diff hit (target 79.52%)

Annotations

Check warning on line 88 in python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py#L88 

Added line #L88 was not covered by tests

Check warning on line 90 in python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py#L90 

Added line #L90 was not covered by tests
View more details on Codecov