Skip to content

Simplify Azure Ai Search Tool #6511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

jay-thakur
Copy link
Contributor

Why are these changes needed?

Simplified the azure ai search tool and fixed bugs in the code

Related issue number

"Closes #6430 "

Checks

Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 83.92857% with 45 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (978cbd2) to head (ac614a7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ogen-ext/src/autogen_ext/tools/azure/_ai_search.py 81.30% 43 Missing ⚠️
...autogen-ext/src/autogen_ext/tools/azure/_config.py 96.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6511      +/-   ##
==========================================
+ Coverage   79.31%   79.52%   +0.20%     
==========================================
  Files         225      225              
  Lines       16694    16641      -53     
==========================================
- Hits        13241    13233       -8     
+ Misses       3453     3408      -45     
Flag Coverage Δ
unittests 79.52% <83.92%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Though work with Ben on ensuring the scenario he has can work would be great.

@ekzhu ekzhu merged commit 87cf4f0 into microsoft:main May 13, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureAISearchTool - Object has no attribute 'semantic_config_name'
2 participants