Skip to content

Conversation

vytautas9
Copy link
Contributor

Using a current version of graph module and particularly graph.list_groups() function is not feasible as the function does not support pagination and returns only top 100 groups.

This PR:

  1. Adds a new graph_pagination function to the _helper_functions.py file which handles the graph api specific pagination (using odata.nextLink)
  2. In the _base_api function, adds conditional statement to check if the client is graph, then perform graph api specific pagination, otherwise - standard Fabric one
  3. Adjusts list functions in graph module to include pagination handling

P.S. Could not test list_sensitivity_labels function so unsure if that one also requires the pagination handling.

@vytautas9
Copy link
Contributor Author

Solves #889

Copy link
Collaborator

@m-kovalsky m-kovalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks. I don't see any documentation regarding pagination for listSensitivityLabels so I think we should be good there.

@m-kovalsky m-kovalsky merged commit fed9461 into microsoft:main Oct 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants