Skip to content

feat: Allow node-notifier to work on Apple Silicon Macs #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Sebastian-Webster
Copy link

@Sebastian-Webster Sebastian-Webster commented Apr 8, 2024

Fixes #361

This was done by recompiling terminal-notifier into a universal binary so it can run on both Intel and Apple Silicon Macs.

The latest macOS SDK at the time of writing (14.4) only supports macOS 10.13 - 14.4 so this will remove support for 10.9 - 10.12. For the no longer supported OS', Growl will be used instead.

@DerZyklop
Copy link

FYI no activity by the owner and main contributor @mikaelbr on this project since 2022.

@mikaelbr
Copy link
Owner

mikaelbr commented May 15, 2025

Technically not true. He closed a spam issue here in 2024.

But yes, practically true, after reaching somewhat stability of the scope of this package and not having used it personally for the last 8 years, maintaining it has become a low priority, and when other maintainers backed off I haven't actively vetted and recruited new maintainers. Problem with PRs like this is that it is vulnerable for supply chain attacks, as we have no checksum and no control of what is actually bundled, which can also trigger some security mechanisms.

@Sebastian-Webster
Copy link
Author

That's a fair point @mikaelbr. I guess a better approach could be to use GitHub Actions to pull the code from the terminal-notifier repository and compile it so it can be openly vetted by anyone? I imagine it won't be worth putting the effort into that if this project isn't actively maintained though.

I just recompiled it as terminal-notifier is no longer actively maintained and didn't support Apple Silicon and I needed it to work on my Apple Silicon Mac without Rosetta being installed. A few months after creating this PR I no longer needed to use node-notifier so I had largely forgotten I created this PR. I'll leave this open in case anyone wants to make use of the changes but it makes sense why this won't be getting merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working on Apple Silicon
3 participants