Support kind: Service as resource
#350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement `kind: services` * adjust Dockerfiles to match go-releaser * add more tests and documentation
# Conflicts: # go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the replicator supports annotated
kind: Servicewhich will be replicated to another namespace astype: ExternalName. This feature allows to cover 2 use casesPlease note:
metadata.annotationsare not replicated by default as on akind: servicethey usually drive load-balancer operators. You can explicitly setreplicator.v1.mittwald.de/strip-annotations: "false"to keep them.replicator.v1.mittwald.de/replicate-tooption implementedkind: Servicewill happily be patched/overwritten ;-)This closes issue #347
Thanks for the very clean code and ease of extensibility which comes with it. Much appreciated 🙏