Skip to content

Initial Feature Flags Support #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Initial Feature Flags Support #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ed8939
initial feature flag support
jaredmixpanel Apr 30, 2025
9477f1d
Merge remote-tracking branch 'origin/master' into jared-feature-flag
jaredmixpanel May 5, 2025
94d929a
initial pass implementation
jaredmixpanel May 6, 2025
5a5935d
fix fetching
jaredmixpanel May 9, 2025
9cfad4e
fix tests
jaredmixpanel May 9, 2025
0275921
remove comments
jaredmixpanel May 9, 2025
54b33be
add tests
jaredmixpanel May 13, 2025
220350b
refactor and add MixpanelOptions
jaredmixpanel May 14, 2025
eec078e
fix builder usage
jaredmixpanel May 14, 2025
7003dc1
some cleanup
jaredmixpanel May 14, 2025
f7a3ae2
add docs to FeatureFlagData
jaredmixpanel May 14, 2025
47ca157
refactor to use new method names and mixpanel.getFlags() API syntax
jaredmixpanel May 14, 2025
6fd1886
separate FeatureFlagDelegate and FeatureFlagManager files
jaredmixpanel May 15, 2025
172d330
revert mixpaneldemo test code
jaredmixpanel May 15, 2025
3c7dad9
remove comma
jaredmixpanel May 15, 2025
e7aa6a4
more renaming
jaredmixpanel May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buildscript {
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:8.1.4'
classpath 'com.android.tools.build:gradle:8.10.0'
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0'
}
}
Expand Down Expand Up @@ -56,7 +56,6 @@ android {
buildTypes {
debug{
minifyEnabled false
debuggable true
testCoverageEnabled true
}
release {
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
20 changes: 18 additions & 2 deletions src/androidTest/java/com/mixpanel/android/mpmetrics/AutomaticEventsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import android.os.HandlerThread;
import android.os.Process;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import androidx.test.filters.SmallTest;
import androidx.test.platform.app.InstrumentationRegistry;
Expand Down Expand Up @@ -63,7 +65,14 @@ public void setUp() {
private void setUpInstance(boolean trackAutomaticEvents) {
final RemoteService mockPoster = new HttpService() {
@Override
public byte[] performRequest(String endpointUrl, ProxyServerInteractor interactor, Map<String, Object> params, SSLSocketFactory socketFactory) {
public byte[] performRequest(
@NonNull String endpointUrl,
@Nullable ProxyServerInteractor interactor,
@Nullable Map<String, Object> params, // Used only if requestBodyBytes is null
@Nullable Map<String, String> headers,
@Nullable byte[] requestBodyBytes, // If provided, send this as raw body
@Nullable SSLSocketFactory socketFactory)
{

final String jsonData = Base64Coder.decodeString(params.get("data").toString());
assertTrue(params.containsKey("data"));
Expand Down Expand Up @@ -212,7 +221,14 @@ public void testAutomaticMultipleInstances() throws InterruptedException {

final HttpService mpSecondPoster = new HttpService() {
@Override
public byte[] performRequest(String endpointUrl, ProxyServerInteractor interactor, Map<String, Object> params, SSLSocketFactory socketFactory) {
public byte[] performRequest(
@NonNull String endpointUrl,
@Nullable ProxyServerInteractor interactor,
@Nullable Map<String, Object> params, // Used only if requestBodyBytes is null
@Nullable Map<String, String> headers,
@Nullable byte[] requestBodyBytes, // If provided, send this as raw body
@Nullable SSLSocketFactory socketFactory)
{
final String jsonData = Base64Coder.decodeString(params.get("data").toString());
assertTrue(params.containsKey("data"));
try {
Expand Down
Loading
Loading