-
Notifications
You must be signed in to change notification settings - Fork 1.4k
WIP: Viz for spatial filters #13332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Viz for spatial filters #13332
Conversation
I'm all for adding nice visualizations for filters/patterns. Suggestion: would a MixedIn pattern make sense here instead of the class you have now? |
Cheers @wmvanvliet! My original thought was to make it usable with external spatial filters (PyRiemann transformers, for example). Does that make sense? If you have an idea how we can work around it with Mixin, I'd be glad to hear |
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.4 → v0.12.5](astral-sh/ruff-pre-commit@v0.12.4...v0.12.5)
What does this implement/fix?
Adds SpatialFilter container for visualisation of filters, patterns and eigenvalues of GED-based algorithms (CSP, SPoC, SSD, XdawnTransformer) and other linear models (LinearModel).