fix: build-using-dockerfile example hangs indefinitely, because EOF is not sent to the pipe #5961
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kujon
force-pushed
the
fix_example
branch
2 times, most recently
from
5e975b2 to
af2197b
Compare
…s not sent to the pipe Signed-off-by: Jakub Korzeniowski <jakub.korzeniowski@gmail.com>
tonistiigi
reviewed
May 7, 2025
There was a problem hiding this comment.
This close should be done by the Output callback in https://github.com/moby/buildkit/pull/5961/files#diff-2c7433fce86ac26cb46ee4f84001b99185ad8c95624d9e61a940238c29247bb1R181 . If it takes WriteCloser it is expected to call Close() on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.