-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable Windows support for BuildKit integration tests #6230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rzlink
wants to merge
1
commit into
moby:master
Choose a base branch
from
rzlink:test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+454
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds comprehensive Windows container support to BuildKit's integration test suite, enabling cross-platform testing while maintaining full Linux compatibility. ## Changes - Updated 35+ integration tests to work on both Windows and Linux - Uses integration.UnixOrWindows() pattern for platform-specific logic - Windows: nanoserver images, cmd.exe commands, C:\ paths, CRLF handling - Linux: preserves existing alpine/busybox images and bash/sh commands - Added platform-specific adaptations for cache, export, frontend, and CLI tests ## Impact - Files: 12 modified (+454/-151 lines) - Coverage: Major test categories now cross-platform compatible - Compatibility: 100% backward compatible, no breaking changes - CI: Enables Windows testing in BuildKit pipeline ## Tests Enhanced - Cache import/export (local, registry, multiple backends) - Image exporters (containerd, OCI, tar, metadata) - Dockerfile frontend parsing and builds - buildctl CLI functionality - Multi-stage builds and named contexts Tests requiring POSIX features (uid/gid, tmpfs, file modes) remain Linux-only.
Summary
Test Status Table
Previously Skipped Tests Now Working on WindowsThese tests were previously skipped on Windows but have been fixed either through source code modifications or by removing unnecessary skip conditions. They now pass successfully on Windows.
Windows-Compatible Tests Failing in GitHub ActionsThese tests have been modified to work on Windows locally but still fail in the GitHub Actions CI environment due to infrastructure, timing, or environment-specific issues.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive Windows container support to BuildKit's integration test suite, enabling cross-platform testing while maintaining full Linux compatibility.
Changes
Tests requiring POSIX features (uid/gid, tmpfs, file modes) remain Linux-only.