Skip to content

New challenges for Rc, Arc, and related Weak implementations #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AlexLB99
Copy link

This PR proposes two new challenges, namely:

  • A challenge for Rc and its related Weak implementation
  • A challenge for Arc and its related Weak implementation

Any feedback is greatly appreciated!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@AlexLB99 AlexLB99 requested a review from a team as a code owner May 27, 2025 20:38
@AlexLB99
Copy link
Author

AlexLB99 commented Jun 6, 2025

Thanks for the review @tautschnig! I've added a new commit that should address your comments

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My comments for the Rc challenge also apply to the Arc one.

Also, you'll need to update SUMMARY.md for your challenges to render in our book. When I do that locally, I get warnings like these:

warning: Potential incomplete link
   ┌─ challenges/0026-rc.md:44:7
   │
44 │ |  Rc<[mem::MaybeUninit<T>],A>::assume_init   |  alloc::rc    |
   │       ^^^^^^^^^^^^^^^^^^^^^ Did you forget to define a URL for `mem::MaybeUninit<T>`?
   │
   = hint: declare the link's URL. For example: `[mem::MaybeUninit<T>]: http://example.com/`

warning: Potential incomplete link
   ┌─ challenges/0026-rc.md:77:7
   │
77 │ |  Rc<[T]>::new_uninit_slice | alloc::rc |
   │       ^^^ Did you forget to define a URL for `T`?
   │
   = hint: declare the link's URL. For example: `[T]: http://example.com/`

Could you fix these? I think you should just be able to wrap the path in a code block like challenge 1 does. You can check the rendering locally by running mdbook serve --open in the doc/ directory.

@AlexLB99
Copy link
Author

AlexLB99 commented Jul 1, 2025

Thanks for the review @carolynzech -- I recently pushed some new commits to address your comments. Please feel free to let me know if there is anything else we could edit/clarify 👍

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carolynzech carolynzech assigned rahulku and unassigned AlexLB99 Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants