Propose Solution for connectorSizing #3774
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Nov 3, 2025
henrikt-ma
reviewed
Nov 3, 2025
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
henrikt-ma
reviewed
Nov 4, 2025
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
henrikt-ma
reviewed
Nov 4, 2025
henrikt-ma
reviewed
Nov 4, 2025
Collaborator
|
My suggested changes to the non-normative paragraph should have converged now. |
henrikt-ma
reviewed
Nov 4, 2025
chapters/annotations.tex
Outdated
| The annotation allows a tool to perform these two actions in many cases automatically. | ||
| This is, e.g., very useful for state machines and for certain components of fluid libraries. | ||
|
|
||
| If a variable \lstinline!n! with \lstinline!connectorSizing = true! does not have exactly one associated vector of connectors, a diagnostic is recommended. |
Collaborator
There was a problem hiding this comment.
Now that the normative text says shall, I think this non-normative paragraph would make more sense without the recommendation to give diagnostics, leaving it to tools to figure out their own ways of dealing with misuse of the annotation.
Github doesn't let me comment on the entire paragraph of three lines, but this suggestion is meant to replace the entire paragraph:
If a variable \lstinline!n! with \lstinline!connectorSizing = true! has multiple associated vectors of connectors, some of the graphical operations described below will not work reliably.
If there is no associated vector of connectors, the user may choose to address this by removing the \lstinline!connectorSizing! annotation.
Collaborator
Author
There was a problem hiding this comment.
I have now added with slight modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3772
It explains the existing use of
n+0.I use "should" to not discuss the edge-cases, in particular:
nwill work in some cases, but not in all cases.