Skip to content

Small friends fixes #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Small friends fixes #4270

wants to merge 5 commits into from
+143 −129

Conversation

Gaming32
Copy link
Collaborator

This PR adds a few small fixes to the friends system in the app

  • Unknown users will now show an error
    • In general, errors returned by labrinth will now be handled in the app
  • Allow the enter key to send a friend request in the Add Friend modal

@Gaming32 Gaming32 added bug Something isn't working enhancement New feature or request app Relates to Modrinth App labels Aug 26, 2025
@IMB11
Copy link
Member

IMB11 commented Aug 26, 2025 •
edited
Loading

Frontend change is fine, did a quick test and it seems that the issues I have been having with it in general are gone

@Gaming32 Gaming32 removed the request for review from Prospector August 26, 2025 17:22
AlexTMjugador
AlexTMjugador approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTMjugador AlexTMjugador AlexTMjugador approved these changes

@IMB11 IMB11 IMB11 approved these changes

Assignees
No one assigned
Labels
app Relates to Modrinth App bug Something isn't working enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gaming32 @IMB11 @AlexTMjugador